From ddb0fdf0a2061430765019875d5cdcef80641993 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 6 Mar 2025 04:58:37 +0000 Subject: [PATCH 1/8] chore: add --max-warnings 0 to all eslint runners and fix warnings Co-Authored-By: Connor Prussin --- apps/api-reference/package.json | 4 ++-- apps/entropy-debugger/package.json | 4 ++-- apps/hermes/client/js/.eslintrc.js | 6 ++++++ apps/hermes/client/js/package.json | 2 +- apps/hermes/client/js/src/examples/HermesClient.ts | 1 + apps/price_pusher/package.json | 2 +- apps/staking/package.json | 4 ++-- apps/staking/src/hooks/use-api.tsx | 1 + contract_manager/package.json | 2 +- governance/pyth_staking_sdk/package.json | 4 ++-- governance/xc_admin/packages/xc_admin_frontend/package.json | 2 +- lazer/sdk/js/package.json | 4 ++-- packages/app-logger/package.json | 4 ++-- packages/fonts/package.json | 4 ++-- packages/known-publishers/package.json | 4 ++-- packages/next-root/package.json | 4 ++-- price_service/client/js/package.json | 2 +- price_service/sdk/js/package.json | 2 +- target_chains/aptos/sdk/js/package.json | 2 +- target_chains/ethereum/sdk/js/package.json | 2 +- target_chains/fuel/sdk/js/package.json | 2 +- .../solana/sdk/js/pyth_solana_receiver/package.json | 2 +- target_chains/solana/sdk/js/solana_utils/package.json | 2 +- target_chains/starknet/sdk/js/package.json | 2 +- target_chains/sui/sdk/js/package.json | 2 +- target_chains/ton/sdk/js/package.json | 2 +- 26 files changed, 40 insertions(+), 32 deletions(-) diff --git a/apps/api-reference/package.json b/apps/api-reference/package.json index 175ec2df6e..1bdd12affe 100644 --- a/apps/api-reference/package.json +++ b/apps/api-reference/package.json @@ -9,12 +9,12 @@ "scripts": { "build": "next build", "fix:format": "prettier --write .", - "fix:lint": "eslint --fix .", + "fix:lint": "eslint --fix . --max-warnings 0", "pull:env": "[ $CI ] || VERCEL_ORG_ID=team_BKQrg3JJFLxZyTqpuYtIY0rj VERCEL_PROJECT_ID=prj_gbljYVzp0m5EpCuOF6nZpM4WMFM6 vercel env pull", "start:dev": "next dev --port 3002", "start:prod": "next start --port 3002", "test:format": "prettier --check .", - "test:lint": "eslint .", + "test:lint": "eslint . --max-warnings 0", "test:types": "tsc" }, "dependencies": { diff --git a/apps/entropy-debugger/package.json b/apps/entropy-debugger/package.json index 6d09c2dd57..61f166c033 100644 --- a/apps/entropy-debugger/package.json +++ b/apps/entropy-debugger/package.json @@ -9,11 +9,11 @@ "scripts": { "build": "next build", "fix:format": "prettier --write .", - "fix:lint": "eslint --fix .", + "fix:lint": "eslint --fix . --max-warnings 0", "start:dev": "next dev --port 3005", "start:prod": "next start --port 3005", "test:format": "prettier --check .", - "test:lint": "eslint .", + "test:lint": "eslint . --max-warnings 0", "test:types": "tsc" }, "dependencies": { diff --git a/apps/hermes/client/js/.eslintrc.js b/apps/hermes/client/js/.eslintrc.js index fca472f38b..6969abb248 100644 --- a/apps/hermes/client/js/.eslintrc.js +++ b/apps/hermes/client/js/.eslintrc.js @@ -3,4 +3,10 @@ module.exports = { parser: "@typescript-eslint/parser", plugins: ["@typescript-eslint"], extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"], + rules: { + "@typescript-eslint/no-unused-vars": [ + "warn", + { argsIgnorePattern: "^_", varsIgnorePattern: "^_" }, + ], + }, }; diff --git a/apps/hermes/client/js/package.json b/apps/hermes/client/js/package.json index 499023f665..cf02c6c446 100644 --- a/apps/hermes/client/js/package.json +++ b/apps/hermes/client/js/package.json @@ -25,7 +25,7 @@ "pull:schema": "curl -o schema.json -z schema.json https://hermes.pyth.network/docs/openapi.json", "example": "node lib/examples/HermesClient.js", "format": "prettier --write \"src/**/*.ts\"", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build:typescript && pnpm run test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run format && git add -A src" diff --git a/apps/hermes/client/js/src/examples/HermesClient.ts b/apps/hermes/client/js/src/examples/HermesClient.ts index 07470b12a0..ab46e6b67c 100644 --- a/apps/hermes/client/js/src/examples/HermesClient.ts +++ b/apps/hermes/client/js/src/examples/HermesClient.ts @@ -89,6 +89,7 @@ async function run() { eventSource.onmessage = (event: MessageEvent) => { console.log("Received price update:", event.data); + // Variable intentionally unused, prefixed with underscore const _priceUpdate = JSON.parse(event.data) as PriceUpdate; }; diff --git a/apps/price_pusher/package.json b/apps/price_pusher/package.json index ebae2094c0..539ccb29b3 100644 --- a/apps/price_pusher/package.json +++ b/apps/price_pusher/package.json @@ -22,7 +22,7 @@ "scripts": { "build": "tsc", "format": "prettier --write \"src/**/*.ts\"", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "start": "node lib/index.js", "dev": "ts-node src/index.ts", "prepublishOnly": "pnpm run build && pnpm run test:lint", diff --git a/apps/staking/package.json b/apps/staking/package.json index 6fcc1741eb..b2885b3191 100644 --- a/apps/staking/package.json +++ b/apps/staking/package.json @@ -9,12 +9,12 @@ "scripts": { "build": "next build", "fix:format": "prettier --write .", - "fix:lint": "eslint --fix .", + "fix:lint": "eslint --fix . --max-warnings 0", "pull:env": "[ $CI ] || VERCEL_ORG_ID=team_BKQrg3JJFLxZyTqpuYtIY0rj VERCEL_PROJECT_ID=prj_3TIYzlYYncZx7wRtfmzG2YUsNzKp vercel env pull", "start:dev": "next dev --port 3001", "start:prod": "next start --port 3001", "test:format": "prettier --check .", - "test:lint": "eslint .", + "test:lint": "eslint . --max-warnings 0", "test:types": "tsc", "test:unit": "jest --selectProjects unit" }, diff --git a/apps/staking/src/hooks/use-api.tsx b/apps/staking/src/hooks/use-api.tsx index d66451b69f..a998b5b8aa 100644 --- a/apps/staking/src/hooks/use-api.tsx +++ b/apps/staking/src/hooks/use-api.tsx @@ -288,6 +288,7 @@ const useApiContext = ( lastStakeAccountMainnet, lastStakeAccountDevnet, mutate, + simulationPayer, ]); }; diff --git a/contract_manager/package.json b/contract_manager/package.json index 676aed91bb..6d7c1dd00b 100644 --- a/contract_manager/package.json +++ b/contract_manager/package.json @@ -11,7 +11,7 @@ "scripts": { "build": "tsc", "shell": "ts-node ./src/shell.ts", - "test:lint": "eslint src/ scripts/", + "test:lint": "eslint src/ scripts/ --max-warnings 0", "format": "prettier --write \"src/**/*.ts\" \"scripts/**/*.ts\"" }, "author": "", diff --git a/governance/pyth_staking_sdk/package.json b/governance/pyth_staking_sdk/package.json index 369d273562..4d52a31f29 100644 --- a/governance/pyth_staking_sdk/package.json +++ b/governance/pyth_staking_sdk/package.json @@ -13,10 +13,10 @@ "scripts": { "build": "tsc", "fix:format": "prettier --write .", - "fix:lint": "eslint --fix .", + "fix:lint": "eslint --fix . --max-warnings 0", "prepublishOnly": "node scripts/update-package-json.mjs", "test:format": "prettier --check .", - "test:lint": "eslint .", + "test:lint": "eslint . --max-warnings 0", "test:types": "tsc" }, "devDependencies": { diff --git a/governance/xc_admin/packages/xc_admin_frontend/package.json b/governance/xc_admin/packages/xc_admin_frontend/package.json index 264235678f..8aa19fc901 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/package.json +++ b/governance/xc_admin/packages/xc_admin_frontend/package.json @@ -10,7 +10,7 @@ "pull:env": "[ $CI ] || VERCEL_ORG_ID=team_BKQrg3JJFLxZyTqpuYtIY0rj VERCEL_PROJECT_ID=prj_TCjesnm3pxM7Ay8oxlTH4xLkkmP9 vercel env pull", "start:dev": "next dev --port 3004", "start:prod": "next start --port 3004", - "test:lint": "next lint" + "test:lint": "next lint --max-warnings 0" }, "dependencies": { "@coral-xyz/anchor": "^0.29.0", diff --git a/lazer/sdk/js/package.json b/lazer/sdk/js/package.json index ac165e0b0c..c534a9bd8f 100644 --- a/lazer/sdk/js/package.json +++ b/lazer/sdk/js/package.json @@ -23,8 +23,8 @@ "scripts": { "build:cjs": "tsc --project tsconfig.build.json --verbatimModuleSyntax false --module commonjs --outDir ./dist/cjs && echo '{\"type\":\"commonjs\"}' > dist/cjs/package.json", "build:esm": "tsc --project tsconfig.build.json --outDir ./dist/esm && echo '{\"type\":\"module\"}' > dist/esm/package.json", - "fix:lint": "eslint --fix .", - "test:lint": "eslint .", + "fix:lint": "eslint --fix . --max-warnings 0", + "test:lint": "eslint . --max-warnings 0", "test:types": "tsc", "example": "node --loader ts-node/esm examples/index.js", "doc": "typedoc --out docs/typedoc src", diff --git a/packages/app-logger/package.json b/packages/app-logger/package.json index 2718927024..b450e4a11f 100644 --- a/packages/app-logger/package.json +++ b/packages/app-logger/package.json @@ -9,9 +9,9 @@ }, "scripts": { "fix:format": "prettier --write .", - "fix:lint": "eslint --fix .", + "fix:lint": "eslint --fix . --max-warnings 0", "test:format": "prettier --check .", - "test:lint": "eslint .", + "test:lint": "eslint . --max-warnings 0", "test:types": "tsc" }, "peerDependencies": { diff --git a/packages/fonts/package.json b/packages/fonts/package.json index 58fb5b786b..af0a0dbca7 100644 --- a/packages/fonts/package.json +++ b/packages/fonts/package.json @@ -6,9 +6,9 @@ "main": "./src/index.ts", "scripts": { "fix:format": "prettier --write .", - "fix:lint": "eslint --fix .", + "fix:lint": "eslint --fix . --max-warnings 0", "test:format": "prettier --check .", - "test:lint": "eslint .", + "test:lint": "eslint . --max-warnings 0", "test:types": "tsc" }, "peerDependencies": { diff --git a/packages/known-publishers/package.json b/packages/known-publishers/package.json index 884ea283e6..b7eb2a1c34 100644 --- a/packages/known-publishers/package.json +++ b/packages/known-publishers/package.json @@ -8,9 +8,9 @@ }, "scripts": { "fix:format": "prettier --write .", - "fix:lint": "eslint --fix .", + "fix:lint": "eslint --fix . --max-warnings 0", "test:format": "prettier --check .", - "test:lint": "eslint .", + "test:lint": "eslint . --max-warnings 0", "test:types": "tsc" }, "peerDependencies": { diff --git a/packages/next-root/package.json b/packages/next-root/package.json index cbe92a4ad7..4fe83fa993 100644 --- a/packages/next-root/package.json +++ b/packages/next-root/package.json @@ -8,9 +8,9 @@ }, "scripts": { "fix:format": "prettier --write .", - "fix:lint": "eslint --fix .", + "fix:lint": "eslint --fix . --max-warnings 0", "test:format": "prettier --check .", - "test:lint": "eslint .", + "test:lint": "eslint . --max-warnings 0", "test:types": "tsc" }, "peerDependencies": { diff --git a/price_service/client/js/package.json b/price_service/client/js/package.json index 04ec0c0598..c75405a1bf 100644 --- a/price_service/client/js/package.json +++ b/price_service/client/js/package.json @@ -24,7 +24,7 @@ "build": "tsc", "example": "pnpm run build && node lib/examples/PriceServiceClient.js", "format": "prettier --write \"src/**/*.ts\"", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build && pnpm run test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run format && git add -A src" diff --git a/price_service/sdk/js/package.json b/price_service/sdk/js/package.json index a6e0dad272..40088d14a8 100644 --- a/price_service/sdk/js/package.json +++ b/price_service/sdk/js/package.json @@ -21,7 +21,7 @@ "format": "prettier --write \"src/**/*.ts\"", "gen-ts-schema": "quicktype --src-lang schema src/schemas/price_feed.json -o src/schemas/PriceFeed.ts --raw-type any --converters all-objects && prettier --write \"src/schemas/*.ts\"", "test:unit": "jest", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build && pnpm test:unit && pnpm run test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run format && git add -A src" diff --git a/target_chains/aptos/sdk/js/package.json b/target_chains/aptos/sdk/js/package.json index 69f4c105c1..7dffa2dade 100644 --- a/target_chains/aptos/sdk/js/package.json +++ b/target_chains/aptos/sdk/js/package.json @@ -23,7 +23,7 @@ "build": "tsc", "example-relay": "pnpm run build && node lib/examples/AptosRelay.js", "format": "prettier --write \"src/**/*.ts\"", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build && pnpm test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run format && git add -A src" diff --git a/target_chains/ethereum/sdk/js/package.json b/target_chains/ethereum/sdk/js/package.json index 6d92b7b037..1a1326adbb 100644 --- a/target_chains/ethereum/sdk/js/package.json +++ b/target_chains/ethereum/sdk/js/package.json @@ -25,7 +25,7 @@ "example-relay": "pnpm run build && node lib/examples/EvmRelay.js", "example-benchmark": "pnpm run build && node lib/examples/EvmBenchmark.js", "format": "prettier --write \"src/**/*.ts\"", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build && pnpm run test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run format && git add -A src" diff --git a/target_chains/fuel/sdk/js/package.json b/target_chains/fuel/sdk/js/package.json index ec6431308a..c6bbc93758 100644 --- a/target_chains/fuel/sdk/js/package.json +++ b/target_chains/fuel/sdk/js/package.json @@ -24,7 +24,7 @@ "build": "pnpm run generate-fuel-types && tsc && copyfiles -u 1 \"src/**/*.d.ts\" lib", "test:format": "prettier --check \"src/**/*.ts\"", "fix:format": "prettier --write \"src/**/*.ts\"", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build && pnpm run test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run test:format && git add -A src", diff --git a/target_chains/solana/sdk/js/pyth_solana_receiver/package.json b/target_chains/solana/sdk/js/pyth_solana_receiver/package.json index 7374c7833e..5212e4a9d1 100644 --- a/target_chains/solana/sdk/js/pyth_solana_receiver/package.json +++ b/target_chains/solana/sdk/js/pyth_solana_receiver/package.json @@ -19,7 +19,7 @@ "scripts": { "build": "tsc", "format": "prettier --write \"src/**/*.ts\"", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build && pnpm test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run format && git add -A src" diff --git a/target_chains/solana/sdk/js/solana_utils/package.json b/target_chains/solana/sdk/js/solana_utils/package.json index e2754ab9d6..29a512f5a2 100644 --- a/target_chains/solana/sdk/js/solana_utils/package.json +++ b/target_chains/solana/sdk/js/solana_utils/package.json @@ -20,7 +20,7 @@ "build": "tsc", "format": "prettier --write \"src/**/*.ts\"", "test:unit": "jest", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build && pnpm test:unit && pnpm run test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run format && git add -A src" diff --git a/target_chains/starknet/sdk/js/package.json b/target_chains/starknet/sdk/js/package.json index 8f485a3e66..9755fc5425 100644 --- a/target_chains/starknet/sdk/js/package.json +++ b/target_chains/starknet/sdk/js/package.json @@ -23,7 +23,7 @@ "build": "tsc", "usage-example": "ts-node src/examples/usage.ts", "format": "prettier --write \"src/**/*.ts\"", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build && pnpm run test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run format && git add -A src" diff --git a/target_chains/sui/sdk/js/package.json b/target_chains/sui/sdk/js/package.json index 5b0a77fb1f..d7674a5121 100644 --- a/target_chains/sui/sdk/js/package.json +++ b/target_chains/sui/sdk/js/package.json @@ -23,7 +23,7 @@ "build": "tsc", "example-relay": "pnpm run build && node lib/examples/SuiRelay.js", "format": "prettier --write \"src/**/*.ts\"", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build && pnpm test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run format && git add -A src" diff --git a/target_chains/ton/sdk/js/package.json b/target_chains/ton/sdk/js/package.json index afcf8c1f0c..a5af45ba8b 100644 --- a/target_chains/ton/sdk/js/package.json +++ b/target_chains/ton/sdk/js/package.json @@ -22,7 +22,7 @@ "scripts": { "build": "tsc", "format": "prettier --write \"src/**/*.ts\"", - "test:lint": "eslint src/", + "test:lint": "eslint src/ --max-warnings 0", "prepublishOnly": "pnpm run build && pnpm run test:lint", "preversion": "pnpm run test:lint", "version": "pnpm run format && git add -A src" From 47b056d26877d0b0974b83ad064939283c453286 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 6 Mar 2025 05:03:42 +0000 Subject: [PATCH 2/8] fix: address CI failures with unused variables in price_service/sdk/js Co-Authored-By: Connor Prussin --- price_service/sdk/js/.eslintrc.js | 1 + .../sdk/js/src/__tests__/AccumulatorUpdateData.test.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/price_service/sdk/js/.eslintrc.js b/price_service/sdk/js/.eslintrc.js index 8fa976bb6e..4bc442c698 100644 --- a/price_service/sdk/js/.eslintrc.js +++ b/price_service/sdk/js/.eslintrc.js @@ -5,5 +5,6 @@ module.exports = { extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"], rules: { "@typescript-eslint/no-explicit-any": "off", + "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }] }, }; diff --git a/price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts b/price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts index 53707b0534..672c111e84 100644 --- a/price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts +++ b/price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts @@ -11,7 +11,7 @@ const TEST_ACCUMULATOR_UPDATE_DATA = describe("Test parse accumulator update", () => { test("Happy path", async () => { - const { vaa, updates } = parseAccumulatorUpdateData( + const { vaa: _vaa, updates } = parseAccumulatorUpdateData( Buffer.from(TEST_ACCUMULATOR_UPDATE_DATA, "base64") ); @@ -73,7 +73,7 @@ describe("Test parse accumulator update", () => { ).updates.length ).toBe(3); - const { vaa, updates } = parseAccumulatorUpdateData( + const { vaa: _vaa, updates } = parseAccumulatorUpdateData( sliceAccumulatorUpdateData( Buffer.from(TEST_ACCUMULATOR_UPDATE_DATA, "base64"), 1, From 7021e2e33a993c0a48121c796e3f807a5fedaac1 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 6 Mar 2025 05:23:51 +0000 Subject: [PATCH 3/8] fix: use eslint-ignore comments instead of modifying eslint configuration Co-Authored-By: Connor Prussin --- apps/hermes/client/js/.eslintrc.js | 6 ------ apps/hermes/client/js/src/examples/HermesClient.ts | 4 ++-- .../client/js/src/__tests__/connection.e2e.test.ts | 5 +++-- price_service/sdk/js/.eslintrc.js | 1 - .../sdk/js/src/__tests__/AccumulatorUpdateData.test.ts | 6 ++++-- 5 files changed, 9 insertions(+), 13 deletions(-) diff --git a/apps/hermes/client/js/.eslintrc.js b/apps/hermes/client/js/.eslintrc.js index 6969abb248..fca472f38b 100644 --- a/apps/hermes/client/js/.eslintrc.js +++ b/apps/hermes/client/js/.eslintrc.js @@ -3,10 +3,4 @@ module.exports = { parser: "@typescript-eslint/parser", plugins: ["@typescript-eslint"], extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"], - rules: { - "@typescript-eslint/no-unused-vars": [ - "warn", - { argsIgnorePattern: "^_", varsIgnorePattern: "^_" }, - ], - }, }; diff --git a/apps/hermes/client/js/src/examples/HermesClient.ts b/apps/hermes/client/js/src/examples/HermesClient.ts index ab46e6b67c..6cb7f31fd7 100644 --- a/apps/hermes/client/js/src/examples/HermesClient.ts +++ b/apps/hermes/client/js/src/examples/HermesClient.ts @@ -89,8 +89,8 @@ async function run() { eventSource.onmessage = (event: MessageEvent) => { console.log("Received price update:", event.data); - // Variable intentionally unused, prefixed with underscore - const _priceUpdate = JSON.parse(event.data) as PriceUpdate; + // eslint-disable-next-line @typescript-eslint/no-unused-vars + const priceUpdate = JSON.parse(event.data) as PriceUpdate; }; eventSource.onerror = (error: Event) => { diff --git a/price_service/client/js/src/__tests__/connection.e2e.test.ts b/price_service/client/js/src/__tests__/connection.e2e.test.ts index 5d26d74a8e..9550711f5c 100644 --- a/price_service/client/js/src/__tests__/connection.e2e.test.ts +++ b/price_service/client/js/src/__tests__/connection.e2e.test.ts @@ -218,10 +218,11 @@ describe("Test websocket endpoints", () => { await sleep(20000); connection.closeWebSocket(); - let seenOutOfOrder = false; + // Check for out of order slots but don't assert on it since it's not stable for (let i = 1; i < observedSlots.length; i++) { if (observedSlots[i] < observedSlots[i - 1]) { - seenOutOfOrder = true; + // Out of order slot found, but we don't assert on it + break; } } diff --git a/price_service/sdk/js/.eslintrc.js b/price_service/sdk/js/.eslintrc.js index 4bc442c698..8fa976bb6e 100644 --- a/price_service/sdk/js/.eslintrc.js +++ b/price_service/sdk/js/.eslintrc.js @@ -5,6 +5,5 @@ module.exports = { extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"], rules: { "@typescript-eslint/no-explicit-any": "off", - "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }] }, }; diff --git a/price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts b/price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts index 672c111e84..6a2724e69e 100644 --- a/price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts +++ b/price_service/sdk/js/src/__tests__/AccumulatorUpdateData.test.ts @@ -11,7 +11,8 @@ const TEST_ACCUMULATOR_UPDATE_DATA = describe("Test parse accumulator update", () => { test("Happy path", async () => { - const { vaa: _vaa, updates } = parseAccumulatorUpdateData( + // eslint-disable-next-line @typescript-eslint/no-unused-vars + const { vaa, updates } = parseAccumulatorUpdateData( Buffer.from(TEST_ACCUMULATOR_UPDATE_DATA, "base64") ); @@ -73,7 +74,8 @@ describe("Test parse accumulator update", () => { ).updates.length ).toBe(3); - const { vaa: _vaa, updates } = parseAccumulatorUpdateData( + // eslint-disable-next-line @typescript-eslint/no-unused-vars + const { vaa, updates } = parseAccumulatorUpdateData( sliceAccumulatorUpdateData( Buffer.from(TEST_ACCUMULATOR_UPDATE_DATA, "base64"), 1, From 55cb71b7005757bc8e58f6080e8c8ffc0cf0e252 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 6 Mar 2025 14:11:59 +0000 Subject: [PATCH 4/8] fix: address eslint warnings in contract_manager package Co-Authored-By: Connor Prussin --- contract_manager/scripts/load_test_entropy.ts | 3 +-- contract_manager/src/chains.ts | 4 +++- contract_manager/src/contracts/sui.ts | 2 +- contract_manager/src/store.ts | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/contract_manager/scripts/load_test_entropy.ts b/contract_manager/scripts/load_test_entropy.ts index 0ffab3bda5..bd9bbad7a1 100644 --- a/contract_manager/scripts/load_test_entropy.ts +++ b/contract_manager/scripts/load_test_entropy.ts @@ -2,7 +2,6 @@ import yargs from "yargs"; import { hideBin } from "yargs/helpers"; import { DefaultStore, EvmChain, toPrivateKey } from "../src"; import { COMMON_DEPLOY_OPTIONS, findEntropyContract } from "./common"; -import Web3 from "web3"; const parser = yargs(hideBin(process.argv)) .usage( @@ -58,7 +57,7 @@ const ABI = [ stateMutability: "nonpayable", type: "function", }, -] as any; +] as any; // eslint-disable-line @typescript-eslint/no-explicit-any async function main() { const argv = await parser.argv; diff --git a/contract_manager/src/chains.ts b/contract_manager/src/chains.ts index 2f49c4543b..449848d260 100644 --- a/contract_manager/src/chains.ts +++ b/contract_manager/src/chains.ts @@ -174,10 +174,12 @@ export class GlobalChain extends Chain { ); } + // eslint-disable-next-line @typescript-eslint/no-unused-vars async getAccountAddress(_privateKey: PrivateKey): Promise { throw new Error("Can not get account for GlobalChain."); } + // eslint-disable-next-line @typescript-eslint/no-unused-vars async getAccountBalance(_privateKey: PrivateKey): Promise { throw new Error("Can not get account balance for GlobalChain."); } @@ -439,7 +441,7 @@ export class EvmChain extends Chain { } async estiamteAndSendTransaction( - transactionObject: any, + transactionObject: any, // eslint-disable-line @typescript-eslint/no-explicit-any txParams: { from?: string; value?: string } ) { const GAS_ESTIMATE_MULTIPLIER = 2; diff --git a/contract_manager/src/contracts/sui.ts b/contract_manager/src/contracts/sui.ts index af8f7d17a6..1d5018e072 100644 --- a/contract_manager/src/contracts/sui.ts +++ b/contract_manager/src/contracts/sui.ts @@ -527,7 +527,7 @@ export class SuiWormholeContract extends WormholeContract { return { id: result.digest, info: result }; } - private async getStateFields(): Promise { + private async getStateFields(): Promise { // eslint-disable-line @typescript-eslint/no-explicit-any const provider = this.chain.getProvider(); const result = await provider.getObject({ id: this.stateId, diff --git a/contract_manager/src/store.ts b/contract_manager/src/store.ts index 4785391488..dc60428526 100644 --- a/contract_manager/src/store.ts +++ b/contract_manager/src/store.ts @@ -234,7 +234,7 @@ export class Store { */ getChainOrThrow( chainId: string, - ChainClass?: { new (...args: any[]): T; type: string } + ChainClass?: { new (...args: any[]): T; type: string } // eslint-disable-line @typescript-eslint/no-explicit-any ): T { const chain = this.chains[chainId]; if (!chain) { From 9b4e0e6323628d9e2ac55aecd7115985d662a9ad Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 6 Mar 2025 14:16:44 +0000 Subject: [PATCH 5/8] chore: add --max-warnings 0 to additional eslint and stylelint runners Co-Authored-By: Connor Prussin --- apps/insights/package.json | 4 ++-- packages/component-library/package.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/insights/package.json b/apps/insights/package.json index 6294c1b63d..fdf4bd3141 100644 --- a/apps/insights/package.json +++ b/apps/insights/package.json @@ -15,8 +15,8 @@ "start:dev": "next dev --port 3003", "start:prod": "next start --port 3003", "test:format": "prettier --check .", - "test:lint:eslint": "eslint .", - "test:lint:stylelint": "stylelint 'src/**/*.scss'", + "test:lint:eslint": "eslint . --max-warnings 0", + "test:lint:stylelint": "stylelint 'src/**/*.scss' --max-warnings 0", "test:types": "tsc" }, "dependencies": { diff --git a/packages/component-library/package.json b/packages/component-library/package.json index ae081ae252..8eca36e9f4 100644 --- a/packages/component-library/package.json +++ b/packages/component-library/package.json @@ -17,8 +17,8 @@ "fix:lint:stylelint": "stylelint --fix 'src/**/*.scss'", "start:dev": "storybook dev --port 4000 --no-open", "test:format": "prettier --check .", - "test:lint:eslint": "eslint .", - "test:lint:stylelint": "stylelint 'src/**/*.scss'", + "test:lint:eslint": "eslint . --max-warnings 0", + "test:lint:stylelint": "stylelint 'src/**/*.scss' --max-warnings 0", "test:types": "tsc" }, "peerDependencies": { From 83af1b9764b9fabb30a802e48a9d06e08c5c4335 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 6 Mar 2025 14:43:00 +0000 Subject: [PATCH 6/8] fix: add eslint-ignore comments to suppress warnings in xc-admin-frontend Co-Authored-By: Connor Prussin --- contract_manager/src/contracts/sui.ts | 3 +- .../components/ClusterSwitch.tsx | 2 +- .../components/PermissionDepermissionKey.tsx | 13 +- .../components/common/Modal.tsx | 2 +- .../components/tabs/General.tsx | 122 ++++++++++-------- .../components/tabs/Proposals/Proposal.tsx | 2 +- .../components/tabs/UpdatePermissions.tsx | 6 +- 7 files changed, 84 insertions(+), 66 deletions(-) diff --git a/contract_manager/src/contracts/sui.ts b/contract_manager/src/contracts/sui.ts index 1d5018e072..ec03d8e8c4 100644 --- a/contract_manager/src/contracts/sui.ts +++ b/contract_manager/src/contracts/sui.ts @@ -527,7 +527,8 @@ export class SuiWormholeContract extends WormholeContract { return { id: result.digest, info: result }; } - private async getStateFields(): Promise { // eslint-disable-line @typescript-eslint/no-explicit-any + private async getStateFields(): Promise { + // eslint-disable-line @typescript-eslint/no-explicit-any const provider = this.chain.getProvider(); const result = await provider.getObject({ id: this.stateId, diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/ClusterSwitch.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/ClusterSwitch.tsx index d2b298c632..1c71d02110 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/ClusterSwitch.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/ClusterSwitch.tsx @@ -10,7 +10,7 @@ const ClusterSwitch = ({ light }: { light?: boolean | null }) => { const { cluster, setCluster } = useContext(ClusterContext) const handleChange = useCallback( - (event: any) => { + (event: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any if (event.target.value) { router.query.cluster = event.target.value setCluster(event.target.value) diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/PermissionDepermissionKey.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/PermissionDepermissionKey.tsx index 9978455251..a3bdffd572 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/PermissionDepermissionKey.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/PermissionDepermissionKey.tsx @@ -57,7 +57,7 @@ const PermissionDepermissionKey = ({ // get current input value - const handleChange = (event: any) => { + const handleChange = (event: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any setSelectedAssetType(event.target.value) setIsModalOpen(true) } @@ -135,7 +135,7 @@ const PermissionDepermissionKey = ({ toast.success(`Proposal sent! 🚀 Proposal Pubkey: ${proposalPubkey}`) setIsSubmitButtonLoading(false) closeModal() - } catch (error: any) { + } catch (error: any) { // eslint-disable-line @typescript-eslint/no-explicit-any if (error.response) { toast.error(capitalizeFirstLetter(error.response.data)) } else { @@ -168,7 +168,14 @@ const PermissionDepermissionKey = ({ }) setPriceAccounts(res) } - }, [rawConfig, dataIsLoading, selectedAssetType, isPermission, publisherKey]) + }, [ + rawConfig, + dataIsLoading, + selectedAssetType, + isPermission, + publisherKey, + cluster, + ]) return ( <> diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/common/Modal.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/common/Modal.tsx index 6893bb3187..3e8c7805d0 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/common/Modal.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/common/Modal.tsx @@ -6,7 +6,7 @@ const Modal: React.FC<{ isModalOpen: boolean setIsModalOpen: Dispatch> closeModal: () => void - content: any + content: any // eslint-disable-line @typescript-eslint/no-explicit-any }> = ({ isModalOpen, setIsModalOpen, closeModal, content }) => { return ( diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx index 5a12ed8aa6..7aa96d3c24 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx @@ -54,8 +54,8 @@ const checkSizeOfProductInstruction = ( } const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { - const [data, setData] = useState({}) - const [dataChanges, setDataChanges] = useState>() + const [data, setData] = useState({}) // eslint-disable-line @typescript-eslint/no-explicit-any + const [dataChanges, setDataChanges] = useState>() // eslint-disable-line @typescript-eslint/no-explicit-any const [existingSymbols, setExistingSymbols] = useState>(new Set()) const [isModalOpen, setIsModalOpen] = useState(false) const [isSendProposalButtonLoading, setIsSendProposalButtonLoading] = @@ -78,12 +78,12 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { setIsModalOpen(false) } - const sortData = (data: any) => { - const sortedData: any = {} + const sortData = (data: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any + const sortedData: any = {} // eslint-disable-line @typescript-eslint/no-explicit-any Object.keys(data) .sort() .forEach((key) => { - const sortedInnerData: any = {} + const sortedInnerData: any = {} // eslint-disable-line @typescript-eslint/no-explicit-any Object.keys(data[key]) .sort() .forEach((innerKey) => { @@ -92,13 +92,16 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { } else if (innerKey === 'priceAccounts') { // sort price accounts by address sortedInnerData[innerKey] = data[key][innerKey].sort( - (priceAccount1: any, priceAccount2: any) => - priceAccount1.address.localeCompare(priceAccount2.address) + ( + priceAccount1: any, // eslint-disable-line @typescript-eslint/no-explicit-any + priceAccount2: any // eslint-disable-line @typescript-eslint/no-explicit-any + ) => priceAccount1.address.localeCompare(priceAccount2.address) ) // sort price accounts keys sortedInnerData[innerKey] = sortedInnerData[innerKey].map( - (priceAccount: any) => { - const sortedPriceAccount: any = {} + (priceAccount: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any + + const sortedPriceAccount: any = {} // eslint-disable-line @typescript-eslint/no-explicit-any Object.keys(priceAccount) .sort() .forEach((priceAccountKey) => { @@ -128,7 +131,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { useEffect(() => { if (!dataIsLoading && rawConfig && rawConfig.mappingAccounts.length > 0) { - const symbolToData: any = {} + const symbolToData: any = {} // eslint-disable-line @typescript-eslint/no-explicit-any rawConfig.mappingAccounts .sort( (mapping1, mapping2) => @@ -164,8 +167,9 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { } }, [rawConfig, dataIsLoading, sortDataMemo, cluster]) - const sortObjectByKeys = (obj: any) => { - const sortedObj: any = {} + const sortObjectByKeys = (obj: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-line @typescript-eslint/no-explicit-any + const sortedObj: any = {} // eslint-disable-line @typescript-eslint/no-explicit-any Object.keys(obj) .sort() .forEach((key) => { @@ -200,7 +204,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { const fileData = e.target.result if (!isValidJson(fileData as string)) return const fileDataParsed = sortData(JSON.parse(fileData as string)) - const changes: Record = {} + const changes: Record = {} // eslint-disable-line @typescript-eslint/no-explicit-any Object.keys(fileDataParsed).forEach((symbol) => { // remove duplicate publishers fileDataParsed[symbol].priceAccounts[0].publishers = [ @@ -249,7 +253,8 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { const isValidJson = (json: string) => { try { JSON.parse(json) - } catch (e: any) { + } catch (e: any) { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-line @typescript-eslint/no-explicit-any toast.error(capitalizeFirstLetter(e.message)) return false } @@ -636,7 +641,8 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { }) } - const MetadataChangesRows = ({ changes }: { changes: any }) => { + const MetadataChangesRows = ({ changes }: { changes: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-line @typescript-eslint/no-explicit-any const addPriceFeed = changes.prev === undefined && changes.new !== undefined return ( <> @@ -668,62 +674,66 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { ) } - const PriceAccountsChangesRows = ({ changes }: { changes: any }) => { + const PriceAccountsChangesRows = ({ changes }: { changes: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any const addPriceFeed = changes.prev === undefined && changes.new !== undefined return ( <> - {changes.new.map((priceAccount: any, index: number) => - Object.keys(priceAccount).map((priceAccountKey) => - priceAccountKey === 'publishers' ? ( - addPriceFeed ? ( - - ) : ( - JSON.stringify(changes.prev[index][priceAccountKey]) !== - JSON.stringify(priceAccount[priceAccountKey]) && ( + {changes.new.map( + ( + priceAccount: any, // eslint-disable-line @typescript-eslint/no-explicit-any + index: number + ) => + Object.keys(priceAccount).map((priceAccountKey) => + priceAccountKey === 'publishers' ? ( + addPriceFeed ? ( + ) : ( + JSON.stringify(changes.prev[index][priceAccountKey]) !== + JSON.stringify(priceAccount[priceAccountKey]) && ( + + ) + ) + ) : ( + (addPriceFeed || + changes.prev[index][priceAccountKey] !== + priceAccount[priceAccountKey]) && ( + + + {priceAccountKey + .split('_') + .map((word) => capitalizeFirstLetter(word)) + .join(' ')} + + + {!addPriceFeed ? ( + <> + {changes.prev[index][priceAccountKey]} +
+ + ) : null} + {priceAccount[priceAccountKey]} + + ) - ) - ) : ( - (addPriceFeed || - changes.prev[index][priceAccountKey] !== - priceAccount[priceAccountKey]) && ( - - - {priceAccountKey - .split('_') - .map((word) => capitalizeFirstLetter(word)) - .join(' ')} - - - {!addPriceFeed ? ( - <> - {changes.prev[index][priceAccountKey]} -
- - ) : null} - {priceAccount[priceAccountKey]} - - ) ) - ) )} ) } - const PublisherKeysChangesRows = ({ changes }: { changes: any }) => { + const PublisherKeysChangesRows = ({ changes }: { changes: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any const addPriceFeed = changes.prev === undefined && changes.new !== undefined const publisherKeysToAdd = addPriceFeed ? changes.new @@ -765,7 +775,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { ) } - const NewPriceFeedsRows = ({ priceFeedData }: { priceFeedData: any }) => { + const NewPriceFeedsRows = ({ priceFeedData }: { priceFeedData: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any return ( <> { ) } - const ModalContent = ({ changes }: { changes: any }) => { + const ModalContent = ({ changes }: { changes: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any return ( <> {Object.keys(changes).length > 0 ? ( diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/Proposal.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/Proposal.tsx index e79b076c24..167f72ab3a 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/Proposal.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/Proposal.tsx @@ -300,7 +300,7 @@ export const Proposal = ({ if (refreshData) await refreshData().fetchData() toast.success(msg) - } catch (e: any) { + } catch (e: any) { // eslint-disable-line @typescript-eslint/no-explicit-any toast.error(capitalizeFirstLetter(e.message)) } finally { setIsTransactionLoading(false) diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/UpdatePermissions.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/UpdatePermissions.tsx index 16bab4b29b..eb5b2410dd 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/UpdatePermissions.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/UpdatePermissions.tsx @@ -216,7 +216,7 @@ const UpdatePermissions = () => { } const handleEditPubkey = ( - e: any, + e: any, // eslint-disable-line @typescript-eslint/no-explicit-any account: PermissionAccount, prevPubkey: string ) => { @@ -280,7 +280,7 @@ const UpdatePermissions = () => { `Proposal sent! 🚀 Proposal Pubkey: ${proposalPubkey}` ) setIsSendProposalButtonLoading(false) - } catch (e: any) { + } catch (e: any) { // eslint-disable-line @typescript-eslint/no-explicit-any toast.error(capitalizeFirstLetter(e.message)) setIsSendProposalButtonLoading(false) } @@ -289,7 +289,7 @@ const UpdatePermissions = () => { } } - const ModalContent = ({ changes }: { changes: any }) => { + const ModalContent = ({ changes }: { changes: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any return ( <> {Object.keys(changes).length > 0 ? ( From 711fa486ce4d9d804de9fd1e30de8f6f2a320a76 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 6 Mar 2025 15:15:00 +0000 Subject: [PATCH 7/8] fix: format eslint-disable comments to be on their own lines Co-Authored-By: Connor Prussin --- .../components/ClusterSwitch.tsx | 3 +- .../components/PermissionDepermissionKey.tsx | 6 ++- .../components/tabs/General.tsx | 43 +++++++++++-------- .../components/tabs/Proposals/Proposal.tsx | 3 +- .../components/tabs/UpdatePermissions.tsx | 6 ++- 5 files changed, 38 insertions(+), 23 deletions(-) diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/ClusterSwitch.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/ClusterSwitch.tsx index 1c71d02110..6488063855 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/ClusterSwitch.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/ClusterSwitch.tsx @@ -10,7 +10,8 @@ const ClusterSwitch = ({ light }: { light?: boolean | null }) => { const { cluster, setCluster } = useContext(ClusterContext) const handleChange = useCallback( - (event: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + (event: any) => { if (event.target.value) { router.query.cluster = event.target.value setCluster(event.target.value) diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/PermissionDepermissionKey.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/PermissionDepermissionKey.tsx index a3bdffd572..de882f5018 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/PermissionDepermissionKey.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/PermissionDepermissionKey.tsx @@ -57,7 +57,8 @@ const PermissionDepermissionKey = ({ // get current input value - const handleChange = (event: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const handleChange = (event: any) => { setSelectedAssetType(event.target.value) setIsModalOpen(true) } @@ -135,7 +136,8 @@ const PermissionDepermissionKey = ({ toast.success(`Proposal sent! 🚀 Proposal Pubkey: ${proposalPubkey}`) setIsSubmitButtonLoading(false) closeModal() - } catch (error: any) { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + } catch (error: any) { if (error.response) { toast.error(capitalizeFirstLetter(error.response.data)) } else { diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx index 7aa96d3c24..163cd6a774 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx @@ -78,12 +78,15 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { setIsModalOpen(false) } - const sortData = (data: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any - const sortedData: any = {} // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const sortData = (data: any) => { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const sortedData: any = {} Object.keys(data) .sort() .forEach((key) => { - const sortedInnerData: any = {} // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const sortedInnerData: any = {} Object.keys(data[key]) .sort() .forEach((innerKey) => { @@ -99,9 +102,10 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { ) // sort price accounts keys sortedInnerData[innerKey] = sortedInnerData[innerKey].map( - (priceAccount: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any - - const sortedPriceAccount: any = {} // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + (priceAccount: any) => { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const sortedPriceAccount: any = {} Object.keys(priceAccount) .sort() .forEach((priceAccountKey) => { @@ -167,9 +171,10 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { } }, [rawConfig, dataIsLoading, sortDataMemo, cluster]) - const sortObjectByKeys = (obj: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any - // eslint-disable-line @typescript-eslint/no-explicit-any - const sortedObj: any = {} // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const sortObjectByKeys = (obj: any) => { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const sortedObj: any = {} Object.keys(obj) .sort() .forEach((key) => { @@ -253,8 +258,8 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { const isValidJson = (json: string) => { try { JSON.parse(json) - } catch (e: any) { // eslint-disable-line @typescript-eslint/no-explicit-any - // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + } catch (e: any) { toast.error(capitalizeFirstLetter(e.message)) return false } @@ -641,8 +646,8 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { }) } - const MetadataChangesRows = ({ changes }: { changes: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any - // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const MetadataChangesRows = ({ changes }: { changes: any }) => { const addPriceFeed = changes.prev === undefined && changes.new !== undefined return ( <> @@ -674,7 +679,8 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { ) } - const PriceAccountsChangesRows = ({ changes }: { changes: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const PriceAccountsChangesRows = ({ changes }: { changes: any }) => { const addPriceFeed = changes.prev === undefined && changes.new !== undefined return ( <> @@ -733,7 +739,8 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { ) } - const PublisherKeysChangesRows = ({ changes }: { changes: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const PublisherKeysChangesRows = ({ changes }: { changes: any }) => { const addPriceFeed = changes.prev === undefined && changes.new !== undefined const publisherKeysToAdd = addPriceFeed ? changes.new @@ -775,7 +782,8 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => { ) } - const NewPriceFeedsRows = ({ priceFeedData }: { priceFeedData: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const NewPriceFeedsRows = ({ priceFeedData }: { priceFeedData: any }) => { return ( <> { ) } - const ModalContent = ({ changes }: { changes: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const ModalContent = ({ changes }: { changes: any }) => { return ( <> {Object.keys(changes).length > 0 ? ( diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/Proposal.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/Proposal.tsx index 167f72ab3a..6ce48ed299 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/Proposal.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals/Proposal.tsx @@ -300,7 +300,8 @@ export const Proposal = ({ if (refreshData) await refreshData().fetchData() toast.success(msg) - } catch (e: any) { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + } catch (e: any) { toast.error(capitalizeFirstLetter(e.message)) } finally { setIsTransactionLoading(false) diff --git a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/UpdatePermissions.tsx b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/UpdatePermissions.tsx index eb5b2410dd..2a73f4805e 100644 --- a/governance/xc_admin/packages/xc_admin_frontend/components/tabs/UpdatePermissions.tsx +++ b/governance/xc_admin/packages/xc_admin_frontend/components/tabs/UpdatePermissions.tsx @@ -280,7 +280,8 @@ const UpdatePermissions = () => { `Proposal sent! 🚀 Proposal Pubkey: ${proposalPubkey}` ) setIsSendProposalButtonLoading(false) - } catch (e: any) { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + } catch (e: any) { toast.error(capitalizeFirstLetter(e.message)) setIsSendProposalButtonLoading(false) } @@ -289,7 +290,8 @@ const UpdatePermissions = () => { } } - const ModalContent = ({ changes }: { changes: any }) => { // eslint-disable-line @typescript-eslint/no-explicit-any + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const ModalContent = ({ changes }: { changes: any }) => { return ( <> {Object.keys(changes).length > 0 ? ( From bba5dff4370cb4bd8785368882a09e97b9624629 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 6 Mar 2025 15:20:26 +0000 Subject: [PATCH 8/8] fix: format eslint-disable comment in contract_manager/src/contracts/sui.ts Co-Authored-By: Connor Prussin --- contract_manager/src/contracts/sui.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contract_manager/src/contracts/sui.ts b/contract_manager/src/contracts/sui.ts index ec03d8e8c4..30fb036b1a 100644 --- a/contract_manager/src/contracts/sui.ts +++ b/contract_manager/src/contracts/sui.ts @@ -527,8 +527,8 @@ export class SuiWormholeContract extends WormholeContract { return { id: result.digest, info: result }; } + // eslint-disable-next-line @typescript-eslint/no-explicit-any private async getStateFields(): Promise { - // eslint-disable-line @typescript-eslint/no-explicit-any const provider = this.chain.getProvider(); const result = await provider.getObject({ id: this.stateId,