Skip to content

Conversation

@ali-behjati
Copy link
Collaborator

@ali-behjati ali-behjati commented Apr 28, 2025

Rationale

The lack of mut annotation is not causing any security risk (because if you pass it as readable it'll fail later when being used as writable). However, it breaks downstream users who rely on the published lib crate of the contract when making CPI to the contract.

How has this been tested?

  • Manually tested the code: the example anchor contract passes tests with this change.

@vercel
Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
entropy-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 1:12pm
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 1:12pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 1:12pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 28, 2025 1:12pm
component-library ⬜️ Ignored (Inspect) Visit Preview Apr 28, 2025 1:12pm
proposals ⬜️ Ignored (Inspect) Visit Preview Apr 28, 2025 1:12pm

@ali-behjati ali-behjati merged commit 82d8685 into main Apr 28, 2025
9 checks passed
@ali-behjati ali-behjati deleted the lazer/add-writable-annotation-anchor branch April 28, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants