refactor(argus): remove fortuna/entropy functionality #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ali-behjati
approved these changes
Apr 30, 2025
| pub final_fee_multiplier: Family<AccountLabel, Histogram>, | ||
| pub gas_price_estimate: Family<AccountLabel, Gauge<f64, AtomicU64>>, | ||
| pub accrued_pyth_fees: Family<ChainIdLabel, Gauge<f64, AtomicU64>>, | ||
| /// Number of active subscriptions per chain |
Collaborator
There was a problem hiding this comment.
for the future i recommend you look at price pusher metrics and get some inspirations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The big chop 🪓
Remove Fortuna functionality from Argus
Rationale
Argus was copy/pasted from Fortuna, which was designed for Entropy's commit/reveal flow. This is largely different from Argus's new role as Pulse's keeper, so this PR resets the project to a clean slate (save the boilerplate,) upon which we can implement the new pusher service.
How has this been tested?