feat(apps/price_pusher): update Aptos balance tracker to use new SDK and improve balance retrieval #2656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove balance retrieval
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cctdaniel
changed the title
ali-behjati
approved these changes
May 6, 2025
|
its still being used in the main price pusher package and im reluctant to replace it since its working for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the Aptos client implementation to use the new
@aptos-labs/ts-sdkinstead of the deprecatedaptospackage, and simplified balance tracking by using the dedicatedgetAccountAPTAmountmethod.Rationale
These changes are necessary to:
How has this been tested?
The changes have been manually tested against both Movement and Aptos chains to ensure the balance tracker correctly fetches and displays token balances. Tests verified that the
getAccountAPTAmountmethod correctly tracks balances regardless of which resource format is used by the chain.