feat(entropy): Add gas tracking for the callback recovery flow #2666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jayantk
commented
May 8, 2025
| EntropyStructs.Request memory reqV1 = EntropyStructConverter | ||
| .toV1Request(req); | ||
| clearRequest(provider, sequenceNumber); | ||
| // WARNING: DO NOT USE req BELOW HERE AS ITS CONTENTS HAS BEEN CLEARED |
Contributor
Author
There was a problem hiding this comment.
referencing req.requester in the prior version of this code wasn't a good idea. (that field doesn't get cleared, but not good to make assumptions about that)
jayantk
commented
May 8, 2025
|
|
||
| // callback gas usage is approximate and only triggered when the provider has set a gas limit. | ||
| // Note: this condition is somewhat janky, but we hit the stack limit so can't put in any more local variables :( | ||
| // callback gas usage is approximate |
Contributor
Author
There was a problem hiding this comment.
Note that other tests of the Revealed event don't check the gas field because it's too hard to predict up front. Thus, we're using vm.expectEmit to only check the topics not the data.
m30m
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As the title says. Track gas usage and emit it in the event.
Rationale
I previously omitted gas tracking in this recovery flow (which is identical to the old callback flow). However, I realized tracking gas will be useful here -- if a user's callback fails and they recover it, they probably want to know how much gas it used so they can set the gas limit better next time.
How has this been tested?