feat(entropy): Minor items to prep for testnet deployments #2673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jayantk
commented
May 12, 2025
| assertTrue( | ||
| random.getProviderInfoV2(provider1).defaultGasLimit == 0 || | ||
| (callbackGasUsed < (callbackGasUsage * 110) / 100) | ||
| assertRevealedEvent( |
Contributor
Author
There was a problem hiding this comment.
extracted the test out to a method. the factoring could be a bit odd because i'm working around the solidity "stack too deep" error
m30m
approved these changes
May 12, 2025
| // 3. A and B reveal x_{A,B} | ||
| // 4. Both parties verify that hash(x_{A, B}) == h_{A,B} | ||
| // 5. The random number r = hash(x_A, x_B) | ||
| // 1. Two parties A and B each randomly sample a contribution x_{A,B} to the random number |
Contributor
There was a problem hiding this comment.
can you update the docs as well to make this consistent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Three minor changes:
How has this been tested?