You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified package.json of three internal packages to pull type for @types/node from the global setting, as defined in pnpm-workspace.yaml.
Rationale
I was running into versioning errors when attempting to initially clone and run turbo build on the target chains Ethereum contract. We noticed that the build error was coming from an issue with the version of node that was being run, and these modifications helped line it up.
@ayushboss looks like you forgot to check in the update to pnpm-lock.yaml, please add that to resolve the CI failures
Thanks for the correction, added that in. It seems like I'm still failing one linting test, so I'm trying to figure out why that might be.
@ayushboss the lint failures are unrelated to your changes, I'm working with the dev who introduced them to get it fixed. You can feel free to merge and ignore those
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified package.json of three internal packages to pull type for @types/node from the global setting, as defined in pnpm-workspace.yaml.
Rationale
I was running into versioning errors when attempting to initially clone and run turbo build on the target chains Ethereum contract. We noticed that the build error was coming from an issue with the version of node that was being run, and these modifications helped line it up.
How has this been tested?
Builds proceed as normal.