-
Notifications
You must be signed in to change notification settings - Fork 277
feat(lazer/sui): initialize #2964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please address my comments before merging.
} | ||
|
||
/// Create a new Feed with the specified parameters | ||
public fun new( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to make this public(crate) because you want when people get a Feed or Update object they be sure it's a valid Feed or Update.
/// Funding rate for derivative products (e.g., perpetual futures) | ||
funding_rate: Option<Option<I64>>, | ||
/// Timestamp when the funding rate was last updated | ||
funding_timestamp: Option<Option<u64>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we just recently added funding_rate_interval.
feeds: vector<Feed>, | ||
} | ||
|
||
public fun new( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Summary
Initializes
pyth_lazer
contract modules and includes a rough draft of a function to parse & verify a Lazer payload based off this example.How has this been tested?