feat(price_pusher): add gauge metrics for source and target price values #3008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add pyth_source_price and pyth_target_price gauge metrics to track latest price values - Update controller to set price value metrics alongside existing timestamp metrics - Use consistent labeling with price_id and alias for metric identification - Convert string prices to numbers for Prometheus gauge compatibility Co-Authored-By: Ali <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 7 Skipped Deployments
|
…ture Co-Authored-By: Ali <[email protected]>
tejasbadadare
approved these changes
Sep 2, 2025
Co-Authored-By: Ali <[email protected]>
…t-manager.devin.ai/proxy/github.com/pyth-network/pyth-crosschain into devin/1756720052-add-price-gauge-metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new Prometheus gauge metrics to the price pusher to track actual price values from both Pyth (source) and target chains:
pyth_source_price{price_id, alias}- Latest price value from Pyth sourcepyth_target_price{price_id, alias}- Latest price value from target chainAlso includes comprehensive documentation updates in the README with example Grafana queries and dashboard descriptions. Version bumped to 10.1.0 for the new functionality.
Rationale
This addresses a debugging need where price discrepancies were observed between UI displays and actual feeds. By exposing the actual price values (not just timestamps) in metrics, operators can monitor and compare price values across different data sources in Grafana dashboards, particularly useful for Solana where the API explorer isn't available.
How has this been tested?
Manual verification:
pnpm turbo buildHuman Review Checklist
Please pay special attention to:
Number(sourcePrice)andNumber(targetPrice)handle all expected price string formats correctly without runtime errors or NaN values/metricsendpoint and can be queried in Grafanapyth_source_priceandpyth_target_pricefollow Prometheus naming standardsLink to Devin run: https://app.devin.ai/sessions/2d00dbc3592645519ae39b8e78dfda4d
Requested by: Ali ([email protected])