feat(express-relay): adding introduction page for express relay #3015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
cprussin
approved these changes
Sep 3, 2025
cprussin
reviewed
Sep 3, 2025
Collaborator
cprussin
left a comment
cprussin
left a comment
There was a problem hiding this comment.
minor nits, not a big deal though
Comment on lines
+16
to
+32
| const colorClasses = { | ||
| blue: { | ||
| bg: "bg-blue-100 dark:bg-blue-900", | ||
| text: "text-blue-600 dark:text-blue-400", | ||
| hoverText: "group-hover:text-blue-600 dark:group-hover:text-blue-400", | ||
| }, | ||
| green: { | ||
| bg: "bg-green-100 dark:bg-green-900", | ||
| text: "text-green-600 dark:text-green-400", | ||
| hoverText: "group-hover:text-green-600 dark:group-hover:text-green-400", | ||
| }, | ||
| purple: { | ||
| bg: "bg-purple-100 dark:bg-purple-900", | ||
| text: "text-purple-600 dark:text-purple-400", | ||
| hoverText: "group-hover:text-purple-600 dark:group-hover:text-purple-400", | ||
| }, | ||
| }; |
Collaborator
There was a problem hiding this comment.
minor but you should extract this to outside the render path since it's constant
Contributor
Author
There was a problem hiding this comment.
fair point, addressed these comments in #3020
| InfoBox: InfoBox, | ||
| // Fuma has a Callout component in `defaultMdxComponents` which we still want to overwrite | ||
| Callout: InfoBox, | ||
| IntegrationCard, |
Collaborator
There was a problem hiding this comment.
Rather than putting this here, just import it where it's used. In general I really dislike putting components here because it makes it really hard to trace from a call site to what's actually included on the page
Contributor
Author
There was a problem hiding this comment.
Sure, will address the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding introduction page for express relay, migrated from the documentation
Rationale
How has this been tested?