refactor: use errors lib

Author: MerlinEgalite

src/adapters/WstEthOracle.sol

@@ -4,6 +4,8 @@ pragma solidity 0.8.21;
 import {IStEth} from "../interfaces/IStEth.sol";
 import {AggregatorV3Interface} from "../interfaces/AggregatorV3Interface.sol";
 
+import {ErrorsLib} from "../libraries/ErrorsLib.sol";
+
 /// @title WstEthOracle
 /// @author Morpho Labs
 /// @custom:contact [email protected]
@@ -17,7 +19,7 @@ contract WstEthOracle is AggregatorV3Interface {
     IStEth public immutable ST_ETH;
 
     constructor(address stEth) {
-        require(stEth != address(0), "WstEthOracle: ZERO_ADDRESS");
+        require(stEth != address(0), ErrorsLib.ZERO_ADDRESS);
         ST_ETH = IStEth(stEth);
     }
 
@@ -27,7 +29,7 @@ contract WstEthOracle is AggregatorV3Interface {
 
     function latestRoundData() public view returns (uint80, int256, uint256, uint256, uint80) {
         uint256 answer = ST_ETH.getPooledEthByShares(10 ** decimals);
-        require(answer < type(uint256).max, "WstEthOracle: OVERFLOW");
+        require(answer < type(uint256).max, ErrorsLib.OVERFLOW);
         return (0, int256(answer), 0, 0, 0);
     }
 }

src/libraries/ErrorsLib.sol

@@ -14,4 +14,10 @@ library ErrorsLib {
 
     /// @notice Thrown when the vault conversion sample is not 1 while vault = address(0).
     string constant VAULT_CONVERSION_SAMPLE_IS_NOT_ONE = "vault conversion sample is not one";
+
+    /// @notice Thrown when the zero address is passed as argument.
+    string constant ZERO_ADDRESS = "zero address";
+
+    /// @notice Thrown when the computation will overflow.
+    string constant OVERFLOW = "overflow";
 }

test/WstEthOracle.sol

@@ -1,6 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 pragma solidity ^0.8.0;
 
+import "../src/libraries/ErrorsLib.sol";
+
 import "../lib/forge-std/src/Test.sol";
 import "../src/adapters/WstEthOracle.sol";
 
@@ -20,7 +22,7 @@ contract ChainlinkOracleTest is Test {
             abi.encodeWithSelector(ST_ETH.getPooledEthByShares.selector, 10 ** 18),
             abi.encode(type(uint256).max)
         );
-        vm.expectRevert("WstEthOracle: OVERFLOW");
+        vm.expectRevert(bytes(ErrorsLib.OVERFLOW));
         oracle.latestRoundData();
     }
 
@@ -30,7 +32,7 @@ contract ChainlinkOracleTest is Test {
             abi.encodeWithSelector(ST_ETH.getPooledEthByShares.selector, 10 ** 18),
             abi.encode(type(uint256).max)
         );
-        vm.expectRevert("WstEthOracle: OVERFLOW");
+        vm.expectRevert(bytes(ErrorsLib.OVERFLOW));
         oracle.getRoundData(1);
     }
 
@@ -39,7 +41,7 @@ contract ChainlinkOracleTest is Test {
     }
 
     function testDeployZeroAddress() public {
-        vm.expectRevert("WstEthOracle: ZERO_ADDRESS");
+        vm.expectRevert(bytes(ErrorsLib.ZERO_ADDRESS));
         new WstEthOracle(address(0));
     }