Skip to content

Commit b77e011

Browse files
Ensure periodic saving fires immediately after runner task is finished (#440)
* Ensure periodic saving fires immediately after runner task is finished * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 88f0258 commit b77e011

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

adaptive/runner.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -839,7 +839,8 @@ def default_save(learner):
839839
async def _saver():
840840
while self.status() == "running":
841841
method(self.learner)
842-
await asyncio.sleep(interval)
842+
# No asyncio.shield needed, as 'wait' does not cancel any tasks.
843+
await asyncio.wait([self.task], timeout=interval)
843844
method(self.learner) # one last time
844845

845846
self.saving_task = self.ioloop.create_task(_saver())

docs/source/tutorial/tutorial.IntegratorLearner.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ jupytext:
44
extension: .md
55
format_name: myst
66
format_version: 0.13
7-
jupytext_version: 1.14.5
7+
jupytext_version: 1.14.7
88
kernelspec:
99
display_name: python3
1010
name: python3
@@ -86,9 +86,7 @@ if not runner.task.done():
8686

8787
```{code-cell} ipython3
8888
print(
89-
"The integral value is {} with the corresponding error of {}".format(
90-
learner.igral, learner.err
91-
)
89+
f"The integral value is {learner.igral} with the corresponding error of {learner.err}"
9290
)
9391
learner.plot()
9492
```

0 commit comments

Comments
 (0)