Skip to content

Commit fcab901

Browse files
committed
Improve test and typing
1 parent f86780f commit fcab901

File tree

7 files changed

+18
-7
lines changed

7 files changed

+18
-7
lines changed

adaptive/learner/average_learner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def to_dataframe(
9898

9999
def load_dataframe(
100100
self,
101-
df,
101+
df: pandas.DataFrame,
102102
with_default_function_args: bool = True,
103103
function_prefix: str = "function.",
104104
seed_name: str = "seed",

adaptive/learner/average_learner1D.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ def to_dataframe(
176176

177177
def load_dataframe(
178178
self,
179-
df,
179+
df: pandas.DataFrame,
180180
with_default_function_args: bool = True,
181181
function_prefix: str = "function.",
182182
seed_name: str = "seed",

adaptive/learner/learner1D.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ def to_dataframe(
351351

352352
def load_dataframe(
353353
self,
354-
df,
354+
df: pandas.DataFrame,
355355
with_default_function_args: bool = True,
356356
function_prefix: str = "function.",
357357
x_name: str = "x",

adaptive/learner/learner2D.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from __future__ import annotations
2+
13
import itertools
24
import warnings
35
from collections import OrderedDict
@@ -415,7 +417,7 @@ def to_dataframe(
415417

416418
def load_dataframe(
417419
self,
418-
df,
420+
df: pandas.DataFrame,
419421
with_default_function_args: bool = True,
420422
function_prefix: str = "function.",
421423
x_name: str = "x",

adaptive/learner/learnerND.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ def to_dataframe(
425425

426426
def load_dataframe(
427427
self,
428-
df,
428+
df: pandas.DataFrame,
429429
with_default_function_args: bool = True,
430430
function_prefix: str = "function.",
431431
point_names: tuple[str, ...] = ("x", "y", "z"),

adaptive/learner/sequence_learner.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from __future__ import annotations
2+
13
from copy import copy
24

35
import cloudpickle
@@ -150,7 +152,7 @@ def to_dataframe(
150152

151153
def load_dataframe(
152154
self,
153-
df,
155+
df: pandas.DataFrame,
154156
with_default_function_args: bool = True,
155157
function_prefix: str = "function.",
156158
index_name: str = "i",

adaptive/tests/test_learners.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -712,6 +712,12 @@ def test_to_dataframe(learner_type, f, learner_kwargs):
712712
kw = {}
713713

714714
learner = learner_type(generate_random_parametrization(f), **learner_kwargs)
715+
716+
# Test empty dataframe
717+
df = learner.to_dataframe()
718+
assert len(df) == 0
719+
720+
# Run the learner
715721
simple_run(learner, 100)
716722
df = learner.to_dataframe(**kw)
717723
assert isinstance(df, pandas.DataFrame)
@@ -721,8 +727,9 @@ def test_to_dataframe(learner_type, f, learner_kwargs):
721727
assert len(df) == learner.npoints
722728

723729
# Add points from the DataFrame to a new empty learner
724-
learner2 = learner_type(generate_random_parametrization(f), **learner_kwargs)
730+
learner2 = learner_type(learner.function, **learner_kwargs)
725731
learner2.load_dataframe(df, **kw)
732+
assert learner2.npoints == learner.npoints
726733

727734
# Test this for a learner in a BalancingLearner
728735
learners = [

0 commit comments

Comments
 (0)