Commit 3aeaae8
authored
Treat deprecations seriously - deprecation in websockets (zauberzeug#5256)
### Motivation
https://websockets.readthedocs.io/en/stable/howto/upgrade.html, and we
have 5 years to migrate.
The deadline is 2030 so we're 5 years early, but I guess that's better
than being late (🤡).
### Implementation
WebSocket protocol configuration:
* Sets the `ws` parameter to `'wsproto'` when configuring the Uvicorn
server in `nicegui/ui_run.py`
* We can choose anything but `auto` (defaults to the websockets legacy)
and `websockets`
* **Personally believe** that by using `wsproto`, which is more
low-level, we may have performance increase.
* But we may use `websockets-sansio` as well.
Test configuration cleanup:
* Removes deprecated warning filters related to the `websockets.legacy`
and `uvicorn.protocols.websockets` modules from the `filterwarnings`
section in `pyproject.toml`, as these are no longer needed.
### Progress
- [x] I chose a meaningful title that completes the sentence: "If
applied, this PR will..."
- [x] The implementation is complete.
- [x] Pytests have been added (or are not necessary).
- [x] Documentation has been added (or is not necessary).1 parent e84e376 commit 3aeaae8
2 files changed
+1
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| 253 | + | |
253 | 254 | | |
254 | 255 | | |
255 | 256 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | | - | |
100 | 98 | | |
101 | 99 | | |
102 | 100 | | |
| |||
0 commit comments