Skip to content

Commit e678213

Browse files
authored
Let pytest run first in the pipeline, startups later. (zauberzeug#5254)
### Motivation There are various issues with running the `test_startup.sh` before the `pytest`, in ascending order of seriousness: 1. Delayed to see the results of the pytest 2. Installation of the example's requirements.txt, **defeats the purpose of having pinned dependencies in `poetry.lock`**, as we can see in https://github.com/zauberzeug/nicegui/actions/runs/18400412564/job/52428146319 that packages indicated in `poetry.lock` are then uninstalled in place of other ones. We can tolerate with point 1 but point 2 definitely needs improvement. This could be the cause of the many errors in zauberzeug#5242. Hence this PR. **Real motivation: I squeezed pytest into 5 minutes in zauberzeug#5249, but I need to wait 10 minutes for `test_startup.sh`?** ### Implementation Move stage `test startup` to the back. ### Progress - [x] I chose a meaningful title that completes the sentence: "If applied, this PR will..." - [x] The implementation is complete. - [x] Pytests have been added (or are not necessary). - [x] Documentation has been added (or is not necessary).
1 parent 1952579 commit e678213

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ jobs:
5050
poetry run pip install -r tests/requirements.txt
5151
# try fix issue with importlib_resources
5252
poetry run pip install importlib-resources
53-
- name: test startup
54-
run: poetry run ./test_startup.sh
5553
- name: setup chromedriver
5654
uses: nanasess/[email protected]
5755
- name: pytest
@@ -63,6 +61,8 @@ jobs:
6361
name: screenshots-${{ matrix.python }}
6462
path: screenshots/*.failed.png
6563
retention-days: 14
64+
- name: test startup
65+
run: poetry run ./test_startup.sh
6666

6767
slack:
6868
needs:

0 commit comments

Comments
 (0)