Fix jobs timeout (#248)

* Fix jobs timeout #247

* Bump codecov-action to v1.5.2

* Fix test

Co-authored-by: Kirill Matveev <[email protected]>

Author: kiriusm2

arq/worker.py

@@ -519,10 +519,9 @@ async def job_failed(exc: BaseException) -> None:
             logger.info('%6.2fs → %s(%s)%s', (start_ms - enqueue_time_ms) / 1000, ref, s, extra)
             self.job_tasks[job_id] = task = self.loop.create_task(function.coroutine(ctx, *args, **kwargs))
 
-            cancel_handler = self.loop.call_at(self.loop.time() + timeout_s, task.cancel)
             # run repr(result) and extra inside try/except as they can raise exceptions
             try:
-                result = await task
+                result = await asyncio.wait_for(task, timeout_s)
             except (Exception, asyncio.CancelledError) as e:
                 exc_extra = getattr(e, 'extra', None)
                 if callable(exc_extra):
@@ -532,7 +531,6 @@ async def job_failed(exc: BaseException) -> None:
                 result_str = '' if result is None else truncate(repr(result))
             finally:
                 del self.job_tasks[job_id]
-                cancel_handler.cancel()
 
         except (Exception, asyncio.CancelledError) as e:
             finished_ms = timestamp_ms()

tests/test_worker.py

@@ -817,3 +817,21 @@ async def wait_and_abort(job, delay=0.1):
     assert worker.aborting_tasks == set()
     assert worker.tasks == {}
     assert worker.job_tasks == {}
+
+
+async def test_job_timeout(arq_redis: ArqRedis, worker, caplog):
+    async def longfunc(ctx):
+        await asyncio.sleep(0.3)
+
+    caplog.set_level(logging.ERROR)
+    await arq_redis.enqueue_job('longfunc', _job_id='testing')
+    worker: Worker = worker(functions=[func(longfunc, name='longfunc')], job_timeout=0.2, poll_delay=0.1)
+    assert worker.jobs_complete == 0
+    assert worker.jobs_failed == 0
+    assert worker.jobs_retried == 0
+    await worker.main()
+    assert worker.jobs_complete == 0
+    assert worker.jobs_failed == 1
+    assert worker.jobs_retried == 0
+    log = re.sub(r'\d+.\d\ds', 'X.XXs', '\n'.join(r.message for r in caplog.records))
+    assert 'X.XXs ! testing:longfunc failed, TimeoutError:' in log