Skip to content

Commit c346dcc

Browse files
author
Nicolas Steinmetz
committed
feat: upgrade to redis-py6 as it supports all python and redis versions
1 parent 5851ffe commit c346dcc

File tree

5 files changed

+3
-10
lines changed

5 files changed

+3
-10
lines changed

arq/connections.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ class RedisSettings:
4949
sentinel: bool = False
5050
sentinel_master: str = 'mymaster'
5151

52-
retry_on_timeout: bool = False
5352
retry_on_error: Optional[list[Exception]] = None
5453
retry: Optional[Retry] = None
5554

@@ -263,7 +262,6 @@ def pool_factory(*args: Any, **kwargs: Any) -> ArqRedis:
263262
ssl_ca_data=settings.ssl_ca_data,
264263
ssl_check_hostname=settings.ssl_check_hostname,
265264
retry=settings.retry,
266-
retry_on_timeout=settings.retry_on_timeout,
267265
retry_on_error=settings.retry_on_error,
268266
max_connections=settings.max_connections,
269267
)

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ classifiers = [
3838
]
3939
requires-python = '>=3.9'
4040
dependencies = [
41-
'redis[hiredis]>=5.3.0,<6',
41+
'redis[hiredis]>=6.0,<7',
4242
'click>=8.0,<8.2',
4343
]
4444
optional-dependencies = {watch = ['watchfiles>=1.0'] }

requirements/pyproject.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ hiredis==3.1.1
1212
# via redis
1313
idna==3.10
1414
# via anyio
15-
pyjwt==2.9.0
16-
# via redis
17-
redis==5.3.0
15+
redis==6.1.0
1816
# via arq (pyproject.toml)
1917
sniffio==1.3.1
2018
# via anyio

tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ async def arq_redis_retry(test_redis_host: str, test_redis_port: int):
8282
port=test_redis_port,
8383
encoding='utf-8',
8484
retry=Retry(backoff=NoBackoff(), retries=3),
85-
retry_on_timeout=True,
8685
retry_on_error=[redis.exceptions.ConnectionError],
8786
)
8887
await redis_.flushall()

tests/test_utils.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def test_settings_changed():
2323
"ssl=False, ssl_keyfile=None, ssl_certfile=None, ssl_cert_reqs='required', ssl_ca_certs=None, "
2424
'ssl_ca_data=None, ssl_check_hostname=False, conn_timeout=1, conn_retries=5, conn_retry_delay=1, '
2525
"max_connections=None, sentinel=False, sentinel_master='mymaster', "
26-
'retry_on_timeout=False, retry_on_error=None, retry=None)'
26+
'retry_on_error=None, retry=None)'
2727
) == str(settings)
2828

2929

@@ -221,7 +221,6 @@ def test_settings_plain():
221221
'conn_retry_delay': 1,
222222
'sentinel': False,
223223
'sentinel_master': 'mymaster',
224-
'retry_on_timeout': False,
225224
'retry_on_error': None,
226225
'retry': None,
227226
'max_connections': None,
@@ -250,7 +249,6 @@ def test_settings_from_socket_dsn():
250249
'conn_retry_delay': 1,
251250
'sentinel': False,
252251
'sentinel_master': 'mymaster',
253-
'retry_on_timeout': False,
254252
'retry_on_error': None,
255253
'retry': None,
256254
'max_connections': None,

0 commit comments

Comments
 (0)