Skip to content

Allow WorkerSettings inheritance #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow WorkerSettings inheritance #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions arq/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,8 +881,12 @@ def __repr__(self) -> str:

def get_kwargs(settings_cls: 'WorkerSettingsType') -> Dict[str, NameError]:
worker_args = set(inspect.signature(Worker).parameters.keys())
d = settings_cls if isinstance(settings_cls, dict) else settings_cls.__dict__
return {k: v for k, v in d.items() if k in worker_args}
if isinstance(settings_cls, dict):
return {k: v for k, v in settings_cls.items() if k in worker_args}
else:
return {
k: getattr(settings_cls, k) for k in dir(settings_cls) if k in worker_args
}


def create_worker(settings_cls: 'WorkerSettingsType', **kwargs: Any) -> Worker:
Expand Down
Loading