Use sys._clear_type_descriptors() on 3.14 to break slot reference cycle #1459
+3
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Jelle thanks for thinking of us! 🥲 I don’t care about pre-release working, so feel free to kill the old workaround and I’ll merge the PR once GHA has rc2 — thanks! |
|
Sounds good! The test suite passes for me locally on 3.14.0rc2 with this version. |
hynek
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #1446. In the latest 3.14 release candidate, we added a
sys._clear_type_descriptorsfunction for dataclasses to use. Let's use that function here too so we don't have to reach into the internals.Note that CPython may end up with a different solution in the future (python/cpython#136966) that would remove the cycle without any need for hacks like this. If that merges, we can add additional conditional logic to skip this logic on 3.15+.
We could also drop the existing manual
__dict__munging entirely; it depends on whether you care about the behavior on earlier 3.14 betas and rc1.