Skip to content

Commit 64cb825

Browse files
committed
Fix keeping unstructuring overrides
1 parent c9d029d commit 64cb825

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/cattrs/gen/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ def make_dict_unstructure_fn(
136136
try:
137137
for a in attrs:
138138
attr_name = a.name
139-
override = kwargs.pop(attr_name, neutral)
139+
override = kwargs.get(attr_name, neutral)
140140
if override.omit:
141141
continue
142142
if override.omit is None and not a.init and not _cattrs_include_init_false:

tests/test_gen_dict.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ def test_renaming(cl_and_vals, data):
201201
cl, converter, **{to_replace.name: override(rename="class")}
202202
)
203203
assert s_fn.overrides == {to_replace.name: override(rename="class")}
204+
assert u_fn.overrides == {to_replace.name: override(rename="class")}
204205

205206
converter.register_structure_hook(cl, s_fn)
206207
converter.register_unstructure_hook(cl, u_fn)

0 commit comments

Comments
 (0)