Tweak error messages

Author: Tinche

src/cattr/converters.py

@@ -492,7 +492,7 @@ def _structure_list(self, obj, cl):
                     try:
                         res.append(handler(e, elem_type))
                     except Exception as e:
-                        e.__note__ = f"Structuring iterable @ index {ix}"
+                        e.__note__ = f"Structuring {cl} @ index {ix}"
                         errors.append(e)
                     finally:
                         ix += 1

src/cattrs/gen.py

@@ -340,7 +340,7 @@ def make_dict_structure_fn(
             lines.append(f"{i}except Exception as e:")
             i = f"{i}  "
             lines.append(
-                f"{i}e.__note__ = 'Structuring class {cl_name} @ attribute {an}'"
+                f"{i}e.__note__ = 'Structuring class {cl.__qualname__} @ attribute {an}'"
             )
             lines.append(f"{i}errors.append(e)")
         post_lines.append(f"  if errors: raise __c_cve('While structuring {cl.__name__}', errors, __cl)")

tests/test_validation.py

@@ -25,10 +25,10 @@ class Test:
     assert repr(exc.value.exceptions[0]) == repr(
         ValueError("invalid literal for int() with base 10: 'a'")
     )
-    assert exc.value.exceptions[0].__note__ == "Structuring class Test @ attribute a"
+    assert exc.value.exceptions[0].__note__ == "Structuring class test_class_validation.<locals>.Test @ attribute a"
 
     assert repr(exc.value.exceptions[1]) == repr(KeyError("c"))
-    assert exc.value.exceptions[1].__note__ == "Structuring class Test @ attribute c"
+    assert exc.value.exceptions[1].__note__ == "Structuring class test_class_validation.<locals>.Test @ attribute c"
 
 
 def test_list_validation():
@@ -41,12 +41,12 @@ def test_list_validation():
     assert repr(exc.value.exceptions[0]) == repr(
         ValueError("invalid literal for int() with base 10: 'a'")
     )
-    assert exc.value.exceptions[0].__note__ == "Structuring iterable @ index 2"
+    assert exc.value.exceptions[0].__note__ == "Structuring typing.List[int] @ index 2"
 
     assert repr(exc.value.exceptions[1]) == repr(
         ValueError("invalid literal for int() with base 10: 'c'")
     )
-    assert exc.value.exceptions[1].__note__ == "Structuring iterable @ index 4"
+    assert exc.value.exceptions[1].__note__ == "Structuring typing.List[int] @ index 4"
 
 
 def test_mapping_validation():