Skip to content

Commit 2e55e5a

Browse files
chore: Enable COM Ruff rules (#15)
1 parent 6308004 commit 2e55e5a

File tree

7 files changed

+26
-20
lines changed

7 files changed

+26
-20
lines changed

backoff/_common.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,14 @@ def _prepare_logger(logger):
6565
# Configure handler list with user specified handler and optionally
6666
# with a default handler bound to the specified logger.
6767
def _config_handlers(
68-
user_handlers, *, default_handler=None, logger=None, log_level=None
68+
user_handlers, *, default_handler=None, logger=None, log_level=None,
6969
):
7070
handlers = []
7171
if logger is not None:
7272
assert log_level is not None, "Log level is not specified"
7373
# bind the specified logger to the default log handler
7474
log_handler = functools.partial(
75-
default_handler, logger=logger, log_level=log_level
75+
default_handler, logger=logger, log_level=log_level,
7676
)
7777
handlers.append(log_handler)
7878

backoff/_decorator.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
_prepare_logger,
99
_config_handlers,
1010
_log_backoff,
11-
_log_giveup
11+
_log_giveup,
1212
)
1313
from backoff._jitter import full_jitter
1414
from backoff import _async, _sync
@@ -89,13 +89,13 @@ def decorate(target):
8989
on_backoff,
9090
default_handler=_log_backoff,
9191
logger=logger,
92-
log_level=backoff_log_level
92+
log_level=backoff_log_level,
9393
)
9494
on_giveup = _config_handlers(
9595
on_giveup,
9696
default_handler=_log_giveup,
9797
logger=logger,
98-
log_level=giveup_log_level
98+
log_level=giveup_log_level,
9999
)
100100

101101
if inspect.iscoroutinefunction(target):
@@ -113,7 +113,7 @@ def decorate(target):
113113
on_success=on_success,
114114
on_backoff=on_backoff,
115115
on_giveup=on_giveup,
116-
wait_gen_kwargs=wait_gen_kwargs
116+
wait_gen_kwargs=wait_gen_kwargs,
117117
)
118118

119119
# Return a function which decorates a target with a retry loop.
@@ -215,7 +215,7 @@ def decorate(target):
215215
on_backoff=on_backoff,
216216
on_giveup=on_giveup,
217217
raise_on_giveup=raise_on_giveup,
218-
wait_gen_kwargs=wait_gen_kwargs
218+
wait_gen_kwargs=wait_gen_kwargs,
219219
)
220220

221221
# Return a function which decorates a target with a retry loop.

backoff/_wait_gen.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
def expo(
99
base: float = 2,
1010
factor: float = 1,
11-
max_value: Optional[float] = None
11+
max_value: Optional[float] = None,
1212
) -> Generator[float, Any, None]:
1313

1414
"""Generator for exponential decay.
@@ -35,7 +35,7 @@ def expo(
3535
def decay(
3636
initial_value: float = 1,
3737
decay_factor: float = 1,
38-
min_value: Optional[float] = None
38+
min_value: Optional[float] = None,
3939
) -> Generator[float, Any, None]:
4040

4141
"""Generator for exponential decay[1]:
@@ -83,7 +83,7 @@ def fibo(max_value: Optional[int] = None) -> Generator[int, None, None]:
8383

8484

8585
def constant(
86-
interval: Union[int, Iterable[float]] = 1
86+
interval: Union[int, Iterable[float]] = 1,
8787
) -> Generator[float, None, None]:
8888
"""Generator for constant intervals.
8989
@@ -104,7 +104,7 @@ def constant(
104104

105105
def runtime(
106106
*,
107-
value: Callable[[Any], float]
107+
value: Callable[[Any], float],
108108
) -> Generator[float, None, None]:
109109
"""Generator that is based on parsing the return value or thrown
110110
exception of the decorated method

backoff/types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
from ._typing import Details
33

44
__all__ = [
5-
'Details'
5+
'Details',
66
]

pyproject.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ description = "format code"
120120
dependency_groups = [ "lint" ]
121121
commands = [
122122
[ "ruff", "check", "--fix", { replace = "posargs", default = [ "backoff", "tests" ], extend = true } ],
123+
# [ "ruff", "format", { replace = "posargs", default = [ "backoff", "tests" ], extend = true } ],
123124
]
124125

125126
[tool.tox.env.lint]
@@ -179,6 +180,11 @@ source = [
179180
"backoff",
180181
]
181182

183+
[tool.ruff.lint]
184+
extend-select = [
185+
"COM", # flake8-commas
186+
]
187+
182188
[build-system]
183189
requires = ["hatchling"]
184190
build-backend = "hatchling.build"

tests/test_backoff.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def test_on_predicate_max_time(monkeypatch):
4949
10.000005,
5050
9,
5151
1,
52-
0
52+
0,
5353
]
5454

5555
def monotonic():
@@ -80,7 +80,7 @@ def test_on_predicate_max_time_callable(monkeypatch):
8080
10.000005,
8181
9,
8282
1,
83-
0
83+
0,
8484
]
8585

8686
def monotonic():
@@ -840,7 +840,7 @@ def key_error():
840840

841841

842842
def _on_exception_factory(
843-
backoff_log_level, giveup_log_level, max_tries
843+
backoff_log_level, giveup_log_level, max_tries,
844844
):
845845
@backoff.on_exception(
846846
backoff.expo,
@@ -860,7 +860,7 @@ def func():
860860

861861

862862
def _on_predicate_factory(
863-
backoff_log_level, giveup_log_level, max_tries
863+
backoff_log_level, giveup_log_level, max_tries,
864864
):
865865
@backoff.on_predicate(
866866
backoff.expo,
@@ -889,17 +889,17 @@ def func():
889889
repeat=2,
890890
)
891891
for factory in (_on_predicate_factory, _on_exception_factory)
892-
)
892+
),
893893
)
894894
def test_event_log_levels(
895-
caplog, func_factory, backoff_log_level, giveup_log_level
895+
caplog, func_factory, backoff_log_level, giveup_log_level,
896896
):
897897
max_tries = 3
898898
func = func_factory(backoff_log_level, giveup_log_level, max_tries)
899899

900900
with unittest.mock.patch('time.sleep', return_value=None):
901901
with caplog.at_level(
902-
min(backoff_log_level, giveup_log_level), logger="backoff"
902+
min(backoff_log_level, giveup_log_level), logger="backoff",
903903
):
904904
func()
905905

tests/test_typing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def foo():
1818
backoff.constant,
1919
ValueError,
2020
interval=1,
21-
max_tries=3
21+
max_tries=3,
2222
)
2323
def bar():
2424
raise ValueError()

0 commit comments

Comments
 (0)