Run linter and type checker in CI

Author: edgarrmondragon

.github/workflows/ci.yaml

@@ -61,6 +61,40 @@ jobs:
           name: coverage-data-${{ matrix.os }}-py${{ matrix.python-version }}
           path: ".coverage.*"
 
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    needs: test
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+
+      - name: Set up Python
+        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@d9e0f98d3fc6adb07d1e3d37f3043649ddad06a1 # v6.5.0
+
+      - name: Run lint
+        run: uvx --with tox-uv tox -e lint
+
+  typing:
+    name: Type checks
+    runs-on: ubuntu-latest
+    needs: test
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+
+      - name: Set up Python
+        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@d9e0f98d3fc6adb07d1e3d37f3043649ddad06a1 # v6.5.0
+
+      - name: Run type checks
+        run: uvx --with tox-uv tox -e typing
+
   coverage:
     name: Coverage
     runs-on: ubuntu-latest

Makefile

@@ -39,18 +39,25 @@ Repository = "https://github.com/python-backoff/backoff"
 
 [dependency-groups]
 dev = [
-    { include-group = "tests" },
-    "flake8>=4.0.1",
-    "mypy>=0.942",
-    "types-requests>=2.27.20",
+    { include-group = "lint" },
+    { include-group = "test" },
+    { include-group = "typing" },
+]
+lint = [
+    "ruff>=0.12.9",
 ]
-tests = [
+test = [
     "coverage>=7.2.7",
     "pytest>=7.1.2",
     "pytest-asyncio>=0.18.3",
     "requests>=2.26.0",
     "responses>=0.20.0",
 ]
+typing = [
+    { include-group = "test" },
+    "mypy>=0.942",
+    "types-requests>=2.27.20",
+]
 
 [tool.hatch.build.targets.sdist]
 include = ["backoff"]
@@ -62,6 +69,7 @@ include = ["backoff"]
 min_version = "4.22"
 requires = [ "tox", "tox-uv" ]
 env_list = [
+  "format",
   "3.7",
   "3.8",
   "3.9",
@@ -70,12 +78,16 @@ env_list = [
   "3.12",
   "3.13",
   "3.14",
+  "lint",
+  "typing",
 ]
 
 [tool.tox.env_run_base]
 description = "run unit tests"
-dependency_groups = [ "tests" ]
-commands = [ [ "coverage", "run", "-m", "pytest", { replace = "posargs", default = [ "tests" ], extend = true } ] ]
+dependency_groups = [ "test" ]
+commands = [
+    [ "coverage", "run", "-m", "pytest", { replace = "posargs", default = [ "tests" ], extend = true } ],
+]
 
 [tool.tox.env.coverage]
 description = "generate coverage report"
@@ -89,13 +101,41 @@ depends = [
   "3.13",
   "3.14",
 ]
-dependency_groups = [ "tests" ]
+dependency_groups = [ "test" ]
 commands = [
   [ "coverage", "combine" ],
   [ "coverage", "report" ],
   [ "coverage", "xml" ],
 ]
 
+[tool.tox.env.format]
+description = "format code"
+dependency_groups = [ "lint" ]
+commands = [
+    [ "ruff", "check", "--fix", { replace = "posargs", default = [ "backoff", "tests" ], extend = true } ],
+]
+
+[tool.tox.env.lint]
+description = "lint code"
+dependency_groups = [ "lint" ]
+commands = [
+    [ "ruff", "check", { replace = "posargs", default = [ "backoff", "tests" ], extend = true } ],
+]
+
+[tool.tox.env.typing]
+description = "run type checking"
+dependency_groups = [ "typing" ]
+commands = [
+  [
+    "mypy",
+    "--show-error-codes",
+    { replace = "posargs", default = [
+      "backoff",
+      "tests",
+    ], extend = true },
+  ],
+]
+
 [tool.pytest.ini_options]
 filterwarnings = [
     "error",

pyproject.toml

@@ -460,9 +460,9 @@ def __init__(self):
     loggers = [Logger() for _ in range(3)]
 
     @backoff.on_predicate(backoff.constant,
-                          on_backoff=(l.backoffs.append for l in loggers),
-                          on_giveup=(l.giveups.append for l in loggers),
-                          on_success=(l.successes.append for l in loggers),
+                          on_backoff=(l.backoffs.append for l in loggers),  # noqa: E741
+                          on_giveup=(l.giveups.append for l in loggers),  # noqa: E741
+                          on_success=(l.successes.append for l in loggers),  # noqa: E741
                           max_tries=3,
                           jitter=None,
                           interval=0)

tests/test_backoff.py

@@ -3,4 +3,4 @@
 from backoff.types import Details
 
 
-assert Details
+assert Details  # type: ignore[truthy-function]