Fix GH-42 -- Remove empty items from the commands’ arguments

Before this commit, if you sent a command like this "/cmd a b  c", the
arguments list will be ["a", "b", "", "c"]. This commit removes every
blank item from that list.

Author: Pietro Albini

botogram/hooks.py

@@ -153,6 +153,9 @@ def _call(self, bot, update):
         return found
 
 
+_command_args_split_re = re.compile(r' +')
+
+
 class CommandHook(Hook):
     """Underlying hook for @bot.command"""
 
@@ -178,7 +181,7 @@ def _call(self, bot, update):
         if match.group(1) and match.group(1) != "@"+bot.itself.username:
             return
 
-        args = text.split(" ")[1:]
+        args = _command_args_split_re.split(text)[1:]
         bot._call(self.func, self.component_id, chat=message.chat,
                   message=message, args=args)
         return True

docs/changelog.rst

@@ -55,6 +55,7 @@ Bug fixes
 * Fix inability to download stickers (`issue 36`_)
 * Fix commands with newlines in the arguments not recognized as such (`issue
   41`_)
+* Remove empty items from the commands' arguments (`issue 42`_)
 
 Deprecated features
 -------------------
@@ -69,6 +70,7 @@ Deprecated features will be removed in botogram 1.0!
 .. _issue 36: https://github.com/pietroalbini/botogram/issues/36
 .. _issue 40: https://github.com/pietroalbini/botogram/issues/40
 .. _issue 41: https://github.com/pietroalbini/botogram/issues/41
+.. _issue 42: https://github.com/pietroalbini/botogram/issues/42
 
 .. _changelog-0.1.2:
 

tests/test_components.py

@@ -222,6 +222,7 @@ def test_add_command(bot, sample_update):
     sample1_processed = False
     sample2_processed = False
     sample3_processed = False
+    sample4_processed = False
 
     def sample1(chat, message, args):
         nonlocal sample1_processed
@@ -232,31 +233,42 @@ def sample2(chat, message, args):
         sample2_processed = True
 
         assert chat.id == -1
-        assert message.text == "/sample2 a b c\nd\te"
+        assert message.text == "/sample2 a b  c\n\nd\t\t\te"
         assert message.chat == chat
         assert args == ["a", "b", "c", "d", "e"]
 
     def sample3(chat, message, args):
         nonlocal sample3_processed
         sample3_processed = True
 
-        assert message.text == "/sample3@test_bot a b c\nd\te"
+        assert message.text == "/sample3@test_bot a b  c\n\nd\t\t\te"
+
+    def sample4(chat, message, args):
+        nonlocal sample4_processed
+        sample4_processed = True
+
+        assert args == []
 
 
     comp = botogram.Component("test")
     comp.add_command("sample1", sample1)
     comp.add_command("sample2", sample2)
     comp.add_command("sample3", sample3)
+    comp.add_command("sample4", sample4)
 
     bot.use(comp)
 
     for cmd in "sample1@another_bot", "sample2", "sample3@test_bot":
-        sample_update.message.text = "/%s a b c\nd\te" % cmd
+        sample_update.message.text = "/%s a b  c\n\nd\t\t\te" % cmd
         bot.process(sample_update)
 
+    sample_update.message.text = "/sample4"
+    bot.process(sample_update)
+
     assert sample1_processed == False
     assert sample2_processed == True
     assert sample3_processed == True
+    assert sample4_processed == True
 
 
 def test_add_shared_memory_initializer(bot, sample_update):