Potential fixes for outstanding multi-line issues in history command

Author: tleonhardt

cmd2/cmd2.py

@@ -302,7 +302,7 @@ class Cmd(cmd.Cmd):
     # Attributes used to configure the StatementParser, best not to change these at runtime
     multiline_commands = []
     shortcuts = {'?': 'help', '!': 'shell', '@': 'load', '@@': '_relative_load'}
-    terminators = [';']
+    terminators = [constants.MULTILINE_TERMINATOR]
 
     # Attributes which are NOT dynamically settable at runtime
     allow_cli_args = True       # Should arguments passed on the command-line be processed as commands?
@@ -3256,7 +3256,10 @@ def do_history(self, args: argparse.Namespace) -> None:
             fd, fname = tempfile.mkstemp(suffix='.txt', text=True)
             with os.fdopen(fd, 'w') as fobj:
                 for command in history:
-                    fobj.write('{}\n'.format(command))
+                    if command.statement.multiline_command:
+                        fobj.write('{}\n'.format(command.expanded.rstrip()))
+                    else:
+                        fobj.write('{}\n'.format(command))
             try:
                 self.do_edit(fname)
                 self.do_load(fname)
@@ -3268,7 +3271,10 @@ def do_history(self, args: argparse.Namespace) -> None:
             try:
                 with open(os.path.expanduser(args.output_file), 'w') as fobj:
                     for command in history:
-                        fobj.write('{}\n'.format(command))
+                        if command.statement.multiline_command:
+                            fobj.write('{}\n'.format(command.expanded.rstrip()))
+                        else:
+                            fobj.write('{}\n'.format(command))
                 plural = 's' if len(history) > 1 else ''
                 self.pfeedback('{} command{} saved to {}'.format(len(history), plural, args.output_file))
             except Exception as e:

cmd2/constants.py

@@ -12,6 +12,7 @@
 REDIRECTION_APPEND = '>>'
 REDIRECTION_CHARS = [REDIRECTION_PIPE, REDIRECTION_OUTPUT]
 REDIRECTION_TOKENS = [REDIRECTION_PIPE, REDIRECTION_OUTPUT, REDIRECTION_APPEND]
+MULTILINE_TERMINATOR = ';'
 
 # Regular expression to match ANSI escape codes
 ANSI_ESCAPE_RE = re.compile(r'\x1b[^m]*m')

cmd2/history.py

@@ -46,13 +46,13 @@ def pr(self, script=False, expanded=False, verbose=False) -> str:
         else:
             if script:
                 # display without entry numbers
-                if expanded:
+                if expanded or self.statement.multiline_command:
                     ret_str = self.expanded.rstrip()
                 else:
                     ret_str = str(self)
             else:
                 # display a numbered list
-                if expanded:
+                if expanded or self.statement.multiline_command:
                     ret_str = self.listformat.format(self.idx, self.expanded.rstrip())
                 else:
                     ret_str = self.listformat.format(self.idx, str(self).rstrip())

cmd2/parsing.py

@@ -191,8 +191,8 @@ def command_and_args(self) -> str:
     def expanded_command_line(self) -> str:
         """Contains command_and_args plus any ending terminator, suffix, and redirection chars"""
         rtn = self.command_and_args
-        if self.terminator:
-            rtn += self.terminator
+        if self.multiline_command:
+            rtn += constants.MULTILINE_TERMINATOR
 
         if self.suffix:
             rtn += ' ' + self.suffix
@@ -240,7 +240,7 @@ def __init__(
     ):
         self.allow_redirection = allow_redirection
         if terminators is None:
-            self.terminators = [';']
+            self.terminators = [constants.MULTILINE_TERMINATOR]
         else:
             self.terminators = terminators
         if multiline_commands is None: