Strip color codes when redirecting w/ ppaged()

Author: ethanmcc

cmd2/cmd2.py

@@ -703,6 +703,9 @@ def ppaged(self, msg: str, end: str='\n', chop: bool=False) -> None:
                         else:
                             break
                     self.pipe_proc = None
+                elif self.redirecting and self.colors.lower() in (constants.COLORS_NEVER.lower(),
+                                                                  constants.COLORS_TERMINAL.lower()):
+                    self.decolorized_write(self.stdout, msg_str)
                 else:
                     self.stdout.write(msg_str)
             except BrokenPipeError:

tests/test_cmd2.py

@@ -2109,6 +2109,24 @@ def test_ppaged(base_app):
     out = base_app.stdout.getvalue()
     assert out == msg + end
 
+def test_ppaged_strips_color_when_redirecting(base_app):
+    msg = 'testing...'
+    end = '\n'
+    base_app.colors = cmd2.constants.COLORS_TERMINAL
+    base_app.redirecting = True
+    base_app.ppaged(Fore.RED + msg)
+    out = base_app.stdout.getvalue()
+    assert out == msg + end
+
+def test_ppaged_strips_color_when_redirecting_if_always(base_app):
+    msg = 'testing...'
+    end = '\n'
+    base_app.colors = cmd2.constants.COLORS_ALWAYS
+    base_app.redirecting = True
+    base_app.ppaged(Fore.RED + msg)
+    out = base_app.stdout.getvalue()
+    assert out == Fore.RED + msg + end
+
 # we override cmd.parseline() so we always get consistent
 # command parsing by parent methods we don't override
 # don't need to test all the parsing logic here, because