Merge branch 'main' into add_argtypes_with_test

Author: tleonhardt

.github/CODEOWNERS

@@ -59,7 +59,6 @@ plugins/*                  @anselor
 
 # Unit and Integration Tests
 tests/*                    @kmvanbrunt @tleonhardt
-tests_isolated/*           @anselor
 
 # Top-level project stuff
 .coveragerc                @tleonhardt

.github/CONTRIBUTING.md

@@ -346,10 +346,9 @@ This bit is up to you!
 
 The cmd2 project directory structure is pretty simple and straightforward. All actual code for cmd2
 is located underneath the `cmd2` directory. The code to generate the documentation is in the `docs`
-directory. Unit tests are in the `tests` directory. Integration tests are in the `tests_isolated`
-directory. The `examples` directory contains examples of how to use cmd2. There are various other
-files in the root directory, but these are primarily related to continuous integration and release
-deployment.
+directory. Unit and integration tests are in the `tests` directory. The `examples` directory
+contains examples of how to use cmd2. There are various other files in the root directory, but these
+are primarily related to continuous integration and release deployment.
 
 #### Changes to the documentation files
 

.github/workflows/tests.yml

@@ -38,11 +38,6 @@ jobs:
       - name: Run tests
         run: uv run python -Xutf8 -m pytest --cov --cov-config=pyproject.toml --cov-report=xml tests
 
-      - name: Run isolated tests
-        run:
-          uv run python -Xutf8 -m pytest --cov --cov-config=pyproject.toml --cov-report=xml
-          tests_isolated
-
       - name: Upload test results to Codecov
         if: ${{ !cancelled() }}
         uses: codecov/test-results-action@v1

CHANGELOG.md

@@ -24,6 +24,7 @@ time reading the [rich documentation](https://rich.readthedocs.io/).
       `value` property
     - Removed redundant setting of a parser's `prog` value in the `with_argparser()` decorator, as
       this is now handled centrally in `Cmd._build_parser()`
+    - The `auto_load_commands` argument to `cmd2.Cmd.__init__` now defaults to `False`
 
 - Enhancements
     - Enhanced all print methods (`poutput()`, `perror()`, `ppaged()`, etc.) to natively render

Makefile

@@ -34,7 +34,6 @@ typecheck: ## Perform type checking
 test: ## Test the code with pytest.
 	@echo "🚀 Testing code: Running pytest"
 	@uv run python -Xutf8 -m pytest --cov --cov-config=pyproject.toml --cov-report=xml tests
-	@uv run python -Xutf8 -m pytest --cov --cov-config=pyproject.toml --cov-report=xml tests_isolated
 
 .PHONY: docs-test
 docs-test: ## Test if documentation can be built without warnings or errors

cmd2/cmd2.py

@@ -323,7 +323,7 @@ def __init__(
         terminators: list[str] | None = None,
         shortcuts: dict[str, str] | None = None,
         command_sets: Iterable[CommandSet] | None = None,
-        auto_load_commands: bool = True,
+        auto_load_commands: bool = False,
         allow_clipboard: bool = True,
         suggest_similar_command: bool = False,
     ) -> None:

cmd2/rich_utils.py

@@ -416,9 +416,9 @@ def _apply_style_wrapper(cls: type[Segment], *args: Any, **kwargs: Any) -> Itera
     styled_segments = list(_orig_segment_apply_style(*args, **kwargs))
     newline_segment = cls.line()
 
-    # If the final segment is a newline, it will be stripped by Segment.split_lines().
+    # If the final segment ends in a newline, that newline will be stripped by Segment.split_lines().
     # Save an unstyled newline to restore later.
-    end_segment = newline_segment if styled_segments and styled_segments[-1].text == "\n" else None
+    end_segment = newline_segment if styled_segments and styled_segments[-1].text.endswith("\n") else None
 
     # Use Segment.split_lines() to separate the styled text from the newlines.
     # This way the ANSI reset code will appear before any newline.

codecov.yml

@@ -14,4 +14,3 @@ component_management:
 ignore:
   - "examples" # ignore example code folder
   - "tests" # ignore unit test code folder
-  - "tests_isolated" # ignore integration test code folder

docs/api/index.md

@@ -2,9 +2,9 @@
 
 These pages document the public API for `cmd2`. If a method, class, function, attribute, or constant
 is not documented here, consider it private and subject to change. There are many classes, methods,
-functions, and constants in the source code which do not begin with an underscore but are not
+functions, and constants in the source code that do not begin with an underscore but are not
 documented here. When looking at the source code for this library, you cannot safely assume that
-because something doesn't start with an underscore, it is a public API.
+something is a public API just because it doesn't start with an underscore.
 
 If a release of this library changes any of the items documented here, the version number will be
 incremented according to the [Semantic Version Specification](https://semver.org).
@@ -18,7 +18,7 @@ incremented according to the [Semantic Version Specification](https://semver.org
 - [cmd2.colors](./colors.md) - StrEnum of all color names supported by the Rich library
 - [cmd2.command_definition](./command_definition.md) - supports the definition of commands in
   separate classes to be composed into cmd2.Cmd
-- [cmd2.constants](./constants.md) - just like it says on the tin
+- [cmd2.constants](./constants.md) - constants used in `cmd2`
 - [cmd2.decorators](./decorators.md) - decorators for `cmd2` commands
 - [cmd2.exceptions](./exceptions.md) - custom `cmd2` exceptions
 - [cmd2.history](./history.md) - classes for storing the history of previously entered commands

docs/doc_conventions.md

@@ -36,7 +36,7 @@ In Markdown all indenting is significant. Use 4 spaces per indenting level.
 
 ## Wrapping
 
-Hard wrap all text so that line lengths are no greater than 120 characters. It makes everything
+Hard wrap all text so that line lengths are no greater than 100 characters. It makes everything
 easier when editing documentation, and has no impact on reading documentation because we render to
 html.
 
@@ -75,9 +75,13 @@ When using `mkdocstrings`, it must be preceded by a blank line before and after,
 
 ### Links to API Reference
 
-To reference a method or function, do the following:
+To reference a class, method, or function, use block quotes around the name of the full namespace
+path for it followed by empty block quotes. So to reference `cmd2.Cmd`, you use `[cmd2.Cmd][]`.
 
-TODO: Figure out how to do this
+If you want to change the name to use something shorter than the full namespace resolution you can
+put the full path in the 2nd set of block quotes instead of leaving it empty and put the shorter
+name in the one on the left. So you could also use `[Cmd][cmd2.Cmd]` to link to the API
+documentation for `cmd2.Cmd`.
 
 ## Referencing cmd2