Skip to content

Commit d3208c8

Browse files
authored
Merge pull request #629 from python-cmd2/auto_complete_overhaul
Auto complete cleanup
2 parents 7b1b8b1 + 53c41ea commit d3208c8

File tree

11 files changed

+106
-683
lines changed

11 files changed

+106
-683
lines changed

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
## 0.9.11 (TBD, 2019)
2+
* Enhancements
3+
* Added ``matches_sort_key`` to override the default way tab completion matches are sorted
4+
* Deprecations
5+
* Deprecated support for bash completion since this feature had slow performance. Also it relied on
6+
``AutoCompleter`` which has since developed a dependency on ``cmd2`` methods.
7+
* Potentially breaking changes
8+
* Made ``cmd2_app`` a positional and required argument of ``AutoCompleter`` since certain functionality now
9+
requires that it can't be ``None``.
10+
* ``AutoCompleter`` no longer assumes ``CompletionItem`` results are sorted. Therefore you should follow the
11+
``cmd2`` convention of setting ``self.matches_sorted`` to True before returning the results if you have already
12+
sorted the ``CompletionItem`` list. Otherwise it will be sorted using ``self.matches_sort_key``.
13+
114
## 0.9.10 (February 22, 2019)
215
* Bug Fixes
316
* Fixed unit test that hangs on Windows

CODEOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ tests/conftest.py @kotfu @tleonhardt
4141
tests/test_acar*.py @anselor
4242
tests/test_argp*.py @kotfu
4343
tests/test_auto*.py @anselor
44-
tests/test_bash*.py @anselor @tleonhardt
4544
tests/test_comp*.py @kmvanbrunt
4645
tests/test_pars*.py @kotfu
4746
tests/test_pysc*.py @anselor

cmd2/argcomplete_bridge.py

Lines changed: 0 additions & 265 deletions
This file was deleted.

0 commit comments

Comments
 (0)