Skip to content

Commit fafdc4b

Browse files
committed
Fixed pyscript unit tests
1 parent c889064 commit fafdc4b

File tree

1 file changed

+13
-17
lines changed

1 file changed

+13
-17
lines changed

tests/test_pyscript.py

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def _do_media_movies(self, args) -> None:
2020
if not args.command:
2121
self.do_help(['media movies'])
2222
else:
23-
print('media movies ' + str(args.__dict__))
23+
self.poutput('media movies ' + str(args.__dict__))
2424

2525
def _do_media_shows(self, args) -> None:
2626
if not args.command:
@@ -29,7 +29,7 @@ def _do_media_shows(self, args) -> None:
2929
if not args.command:
3030
self.do_help(['media shows'])
3131
else:
32-
print('media shows ' + str(args.__dict__))
32+
self.poutput('media shows ' + str(args.__dict__))
3333

3434
media_parser = argparse_completer.ACArgumentParser(prog='media')
3535

@@ -84,7 +84,7 @@ def do_media(self, args):
8484

8585
@with_argparser(foo_parser)
8686
def do_foo(self, args):
87-
print('foo ' + str(args.__dict__))
87+
self.poutput('foo ' + str(args.__dict__))
8888
if self._in_py:
8989
FooResult = namedtuple_with_defaults('FooResult',
9090
['counter', 'trueval', 'constval',
@@ -110,7 +110,7 @@ def do_bar(self, args):
110110
out += '{'
111111
for key in keys:
112112
out += "'{}':'{}'".format(key, arg_dict[key])
113-
print(out)
113+
self.poutput(out)
114114

115115

116116
@pytest.fixture
@@ -126,7 +126,7 @@ def __init__(self):
126126
self.pyscript_name = 'custom'
127127

128128
def do_echo(self, out):
129-
print(out)
129+
self.poutput(out)
130130

131131

132132
@pytest.fixture
@@ -172,13 +172,11 @@ def test_pyscript_help(ps_app, capsys, request, command, pyscript_file):
172172
def test_pyscript_out(ps_app, capsys, request, command, pyscript_file):
173173
test_dir = os.path.dirname(request.module.__file__)
174174
python_script = os.path.join(test_dir, 'pyscript', pyscript_file)
175-
run_cmd(ps_app, command)
176-
expected, _ = capsys.readouterr()
175+
expected = run_cmd(ps_app, command)
176+
assert expected
177177

178-
assert len(expected) > 0
179-
run_cmd(ps_app, 'pyscript {}'.format(python_script))
180-
out, _ = capsys.readouterr()
181-
assert len(out) > 0
178+
out = run_cmd(ps_app, 'pyscript {}'.format(python_script))
179+
assert out
182180
assert out == expected
183181

184182

@@ -227,14 +225,12 @@ def test_pyscript_dir(ps_app, capsys, request, expected, pyscript_file):
227225
assert out == expected
228226

229227

230-
def test_pyscript_custom_name(ps_echo, capsys, request):
228+
def test_pyscript_custom_name(ps_echo, request):
231229
message = 'blah!'
232230

233231
test_dir = os.path.dirname(request.module.__file__)
234232
python_script = os.path.join(test_dir, 'pyscript', 'custom_echo.py')
235233

236-
run_cmd(ps_echo, 'pyscript {}'.format(python_script))
237-
expected, _ = capsys.readouterr()
238-
assert len(expected) > 0
239-
expected = expected.splitlines()
240-
assert message == expected[0]
234+
out = run_cmd(ps_echo, 'pyscript {}'.format(python_script))
235+
assert out
236+
assert message == out[0]

0 commit comments

Comments
 (0)