Styled string conversion #1489
Merged
Styled string conversion #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 23 23
Lines 4911 4917 +6
=======================================
+ Hits 4851 4857 +6
Misses 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tleonhardt
previously approved these changes
Aug 26, 2025
tleonhardt
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few issues related to converting strings to Text before rendering.
Previously we converted all non-Rich objects to a Text object. Now we only convert strings which contain ANSI styles.
Rich only looks for markup, emojis, and highlighting in strings. Therefore we were losing this capability since they had been converted to Text objects. Additionally, we lost pretty printing on objects like dictionaries because they also had been converted to Text by our code.
Finally, I fixed an issue with incorrect display widths of styled_strings in CompletionItems descriptions.