Move two test files that don't need to be isolated #1519
Conversation
…d to tests Also: - Remove unnecessary nested directory under tests_isolated for the one remaining test file there. This is the first step in fixing the tests so none of them need to be isolated. The tests in tests_isolated/test_commandset.py follow bad practices where classes are modified instead of instances of classes.
|
🤖 Hi @tleonhardt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
==========================================
- Coverage 98.92% 98.90% -0.03%
==========================================
Files 21 21
Lines 4933 4933
==========================================
- Hits 4880 4879 -1
- Misses 53 54 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This pull request refactors the test suite by moving tests from the tests_isolated directory to the tests directory and adding a new ExternalTestMixin to tests/conftest.py to help with testing. The changes are well-structured and improve the organization of the tests.
🔍 General Feedback
- The new
ExternalTestMixinis a great addition for testingcmd2applications. - The docstrings in the new mixin could be more descriptive to improve clarity and maintainability.
…nftest.py based on PR comments from gemini-cli
Move two test files that don't need to be isolated from
tests_isolateddirectory totestsdirectory.Also:
This is the first step in fixing the tests so none of them need to be isolated. The tests in
tests_isolated/test_commandset.pyfollow bad practices where classes are modified instead of instances of classes.