Skip to content

Commit 7a3cfd6

Browse files
committed
Remove always-true if in field_for_schema()
From what I can tell this condition can only be true if the calling code doubly accessses internal things such as: ```python3 attr.ib(default=1, metadata={desert._make._DESERT_SENTINEL:{'required': True}}) ```
1 parent 6b30cd2 commit 7a3cfd6

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/desert/_make.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -213,10 +213,7 @@ def field_for_schema(
213213
if default is not marshmallow.missing:
214214
desert_metadata.setdefault("default", default)
215215
desert_metadata.setdefault("allow_none", True)
216-
if not desert_metadata.get(
217-
"required"
218-
): # 'missing' must not be set for required fields.
219-
desert_metadata.setdefault("missing", default)
216+
desert_metadata.setdefault("missing", default)
220217

221218
field = None
222219

0 commit comments

Comments
 (0)