fix: don't create a new session to upload to the pastebin (#3388)

* fix: don't create a new session to upload to the pastebin

noticed this earlier but didn't see it get fixed
this is a simple fix that lessens creating an
unnecessary session

* fix the other two instances

https://discord.com/channels/267624335836053506/291284109232308226/1419909021460336680

Author: onerandomusername

bot/decorators.py

@@ -6,7 +6,6 @@
 
 import arrow
 import discord
-from aiohttp import ClientSession
 from discord import Member, NotFound
 from discord.ext import commands
 from discord.ext.commands import Cog, Context
@@ -159,17 +158,16 @@ async def inner(self: Cog, ctx: Context, *args, **kwargs) -> None:
 
             paste_response = None
             if RedirectOutput.delete_invocation:
-                async with ClientSession() as session:
-                    try:
-                        paste_response = await send_to_paste_service(
-                            files=[PasteFile(content=ctx.message.content, lexer="markdown")],
-                            http_session=session,
-                        )
-                    except PasteUploadError:
-                        log.exception(
-                            "Failed to upload message %d in channel %d to paste service when redirecting output",
-                            ctx.message.id, ctx.message.channel.id
-                        )
+                try:
+                    paste_response = await send_to_paste_service(
+                        files=[PasteFile(content=ctx.message.content, lexer="markdown")],
+                        http_session=ctx.bot.http_session,
+                    )
+                except PasteUploadError:
+                    log.exception(
+                        "Failed to upload message %d in channel %d to paste service when redirecting output",
+                        ctx.message.id, ctx.message.channel.id
+                    )
 
             msg = "Here's the output of "
             msg += f"[your command]({paste_response.link})" if paste_response else "your command"

bot/exts/utils/attachment_pastebin_uploader.py

@@ -2,7 +2,6 @@
 
 import re
 
-import aiohttp
 import discord
 from discord.ext import commands
 from pydis_core.utils import paste_service
@@ -116,8 +115,7 @@ async def on_message(self, message: discord.Message) -> None:
         # Upload the files to the paste bin, exiting early if there's an error.
         log.trace(f"Attempting to upload {len(files)} file(s) to pastebin.")
         try:
-            async with aiohttp.ClientSession() as session:
-                paste_response = await paste_service.send_to_paste_service(files=files, http_session=session)
+            paste_response = await paste_service.send_to_paste_service(files=files, http_session=self.bot.http_session)
         except (paste_service.PasteTooLongError, ValueError):
             log.trace(f"{message.author}'s attachments were too long.")
             await bot_reply.edit(content="Your paste is too long, and couldn't be uploaded.")
@@ -145,8 +143,7 @@ async def on_message(self, message: discord.Message) -> None:
             return
 
         # Delete the paste and the bot's message.
-        async with aiohttp.ClientSession() as session:
-            await session.get(paste_response.removal)
+        await self.bot.http_session.get(paste_response.removal)
 
         await bot_reply.delete()