Update old schemas and routes to use new ORM layout

Author: ChrisLovering

api/main.py

@@ -2,7 +2,7 @@
 from starlette.middleware.authentication import AuthenticationMiddleware
 
 from api.middleware import TokenAuthentication, on_auth_error
-from api.routers.old import old_routes_router
+from api.routers.v1 import v1_routes_router
 from api.settings import Server
 
 app = FastAPI(redoc_url="/", docs_url="/swagger")
@@ -13,4 +13,4 @@
     on_error=on_auth_error,
 )
 
-app.include_router(old_routes_router)
+app.include_router(v1_routes_router)

api/models/orm/infraction.py

@@ -17,7 +17,7 @@ class Infraction(Base):
     user_id: Mapped[int] = mapped_column(ForeignKey("users.user_id"))
     issued_in_jam_id: Mapped[int] = mapped_column(ForeignKey("jams.jam_id"))
     infraction_type: Mapped[InfractionType] = mapped_column(
-        Enum(*InfractionType.__args__, name="infraction_type_enum"),
+        Enum(*InfractionType.__args__, name="infraction_type"),
         nullable=False,
     )
     reason: Mapped[str] = mapped_column(String(), nullable=False)

api/models/schemas/old/infraction.py

@@ -0,0 +1,5 @@
+def discord_ids_must_be_snowflake(field_to_check: int) -> int:
+    """Ensure the ids are valid Discord snowflakes."""
+    if field_to_check and field_to_check.bit_length() > 64:
+        raise ValueError("Field must fit within a 64 bit int.")
+    return field_to_check

api/models/schemas/utils.py

@@ -0,0 +1,31 @@
+from pydantic import BaseModel, validator
+
+from api.models.orm.infraction import InfractionType
+from api.models.schemas.utils import discord_ids_must_be_snowflake
+
+
+class InfractionBase(BaseModel):
+    """Base model for all infraction types."""
+
+    user_id: int
+    jam_id: int
+    reason: str
+    infraction_type: InfractionType
+
+    # validators
+    _ensure_valid_discord_id = validator("user_id", allow_reuse=True)(discord_ids_must_be_snowflake)
+
+
+class InfractionCreate(InfractionBase):
+    """The expected fields to create a new infraction."""
+
+
+class Infraction(InfractionBase):
+    """A model representing an infraction."""
+
+    id: int
+
+    class Config:
+        """Sets ORM mode to true so that pydantic will validate the objects returned by SQLAlchemy."""
+
+        orm_mode = True

api/models/schemas/v1/infraction.py

@@ -1,22 +1,25 @@
 from pydantic import BaseModel
 
-from api.models.schemas.old import infraction, team, winner
+from api.models.schemas.v1 import infraction, team, winner
 
 
-class CodeJam(BaseModel):
-    """A model representing a codejam."""
+class CodeJamBase(BaseModel):
+    """A Base model representing a codejam."""
 
     name: str
     teams: list[team.Team]
     ongoing: bool = False
 
 
-class CodeJamResponse(CodeJam):
+class CodeJamCreate(CodeJamBase):
+    """The expected fields to create a new Code Jam."""
+
+
+class CodeJam(CodeJamBase):
     """Response model representing a code jam."""
 
     id: int
-    teams: list[team.TeamResponse]
-    infractions: list[infraction.InfractionResponse]
+    infractions: list[infraction.Infraction]
     winners: list[winner.Winner]
 
     class Config:

api/models/schemas/old/jam.py renamed to api/models/schemas/v1/jam.py

@@ -2,19 +2,19 @@
 
 from pydantic import BaseModel
 
-from api.models.schemas.old import user
+from api.models.schemas.v1 import user
 
 
-class Team(BaseModel):
-    """A model representing a team for a codejam."""
+class TeamBase(BaseModel):
+    """A Base model representing a team for a codejam."""
 
     name: str
     users: list[user.User]
     discord_role_id: Optional[int] = None
     discord_channel_id: Optional[int] = None
 
 
-class TeamResponse(Team):
+class Team(TeamBase):
     """Response model representing a team."""
 
     id: int
@@ -26,11 +26,11 @@ class Config:
         orm_mode = True
 
 
-class UserTeamResponse(BaseModel):
-    """Response model representing user and team relationship."""
+class UserTeam(BaseModel):
+    """A model representing user and team relationship."""
 
     user_id: int
-    team: TeamResponse
+    team: Team
     is_leader: bool
 
     class Config:

api/models/schemas/old/team.py renamed to api/models/schemas/v1/team.py

@@ -1,18 +1,6 @@
 from pydantic import BaseModel
 
-from api.models.schemas.old import infraction
-
-
-class User(BaseModel):
-    """A model representing a user for a codejam."""
-
-    user_id: int
-    is_leader: bool
-
-    class Config:
-        """Sets ORM mode to true so that pydantic will validate the objects returned by SQLAlchemy."""
-
-        orm_mode = True
+from api.models.schemas.v1 import infraction
 
 
 class ParticipationHistory(BaseModel):
@@ -23,18 +11,23 @@ class ParticipationHistory(BaseModel):
     first_place: bool
     team_id: int
     is_leader: bool
-    infractions: list[infraction.InfractionResponse]
+    infractions: list[infraction.Infraction]
 
     class Config:
         """Sets ORM mode to true so that pydantic will validate the objects returned by SQLAlchemy."""
 
         orm_mode = True
 
 
-class UserResponse(BaseModel):
-    """Response model representing a user."""
+class UserBase(BaseModel):
+    """A Base model representing core data about a user."""
 
     id: int
+
+
+class User(UserBase):
+    """Response model representing everything about a user."""
+
     participation_history: list[ParticipationHistory]
 
     class Config: