Ensure requested condorcet calculations are on vote components

jb3 · jb3 · commit 3b6464f25a8b · 2024-07-11T22:44:19.000+01:00
diff --git a/backend/routes/forms/condorcet.py b/backend/routes/forms/condorcet.py
@@ -78,6 +78,11 @@ async def get(self, request: Request) -> JSONResponse:
                 detail="Requested more winners than there are candidates", status_code=400
             )
 
+        if question.type != "vote":
+            raise InvalidCondorcetRequest(
+                detail="Requested question is not a condorcet vote component", status_code=400
+            )
+
         cursor = request.state.db.responses.find(
             {"form_id": form_id},
         )

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,11 @@ async def get(self, request: Request) -> JSONResponse:`
`78`	`78`	`detail="Requested more winners than there are candidates", status_code=400`
`79`	`79`	`)`
`80`	`80`
	`81`	`+ if question.type != "vote":`
	`82`	`+ raise InvalidCondorcetRequest(`
	`83`	`+ detail="Requested question is not a condorcet vote component", status_code=400`
	`84`	`+ )`
	`85`	`+`
`81`	`86`	`cursor = request.state.db.responses.find(`
`82`	`87`	`{"form_id": form_id},`
`83`	`88`	`)`