Code updates for new linter version

Author: jb3

bot/exts/advent_of_code/_helpers.py

@@ -477,7 +477,7 @@ async def countdown_status(bot: SirRobin) -> None:
     while arrow.now(EST) < end:
         _, time_left = time_left_to_est_midnight()
 
-        aligned_seconds = int(math.ceil(time_left.seconds / COUNTDOWN_STEP)) * COUNTDOWN_STEP
+        aligned_seconds = math.ceil(time_left.seconds / COUNTDOWN_STEP) * COUNTDOWN_STEP
         hours, minutes = aligned_seconds // 3600, aligned_seconds // 60 % 60
 
         if aligned_seconds == 0:

bot/exts/smart_eval/_cog.py

@@ -64,7 +64,7 @@ async def improve_gpu_name(self, hardware_name: str) -> str:
     async def donations(self, ctx: commands.Context) -> None:
         """Display the number of donations recieved so far."""
         total_donations = await self.total_donations()
-        response_time, intelligence_level = await self.get_gpu_capabilities()
+        _response_time, intelligence_level = await self.get_gpu_capabilities()
         msg = (
             f"Currently, I have received {total_donations} GPU donations, "
             f"and am at intelligence level {intelligence_level}! "
@@ -138,7 +138,7 @@ async def donate(self, ctx: commands.Context, *, hardware: str | None = None) ->
     @commands.max_concurrency(1, commands.BucketType.user)
     async def smart_eval(self, ctx: commands.Context, *, code: str) -> None:
         """Evaluate your Python code with PyDis's newest chatbot."""
-        response_time, intelligence_level = await self.get_gpu_capabilities()
+        response_time, _intelligence_level = await self.get_gpu_capabilities()
 
         if match := FORMATTED_CODE_REGEX.match(code):
             code = match.group("code")

tests/helpers.py

@@ -1,5 +1,3 @@
-from __future__ import annotations
-
 import collections
 import itertools
 import logging
@@ -143,6 +141,46 @@ def _get_child_mock(self, **kw):
 }
 guild_instance = discord.Guild(data=guild_data, state=unittest.mock.MagicMock())
 
+# Create a Role instance to get a realistic Mock of `discord.Role`
+role_data = {"name": "role", "id": 1}
+role_instance = discord.Role(guild=guild_instance, state=unittest.mock.MagicMock(), data=role_data)
+
+class MockRole(CustomMockMixin, unittest.mock.Mock, ColourMixin, HashableMixin):
+    """
+    A Mock subclass to mock `discord.Role` objects.
+
+    Instances of this class will follow the specifications of `discord.Role` instances. For more
+    information, see the `MockGuild` docstring.
+    """
+    spec_set = role_instance
+
+    def __init__(self, **kwargs) -> None:
+        default_kwargs = {
+            "id": next(self.discord_id),
+            "name": "role",
+            "position": 1,
+            "colour": discord.Colour(0xdeadbf),
+            "permissions": discord.Permissions(),
+        }
+        super().__init__(**collections.ChainMap(kwargs, default_kwargs))
+
+        if isinstance(self.colour, int):
+            self.colour = discord.Colour(self.colour)
+
+        if isinstance(self.permissions, int):
+            self.permissions = discord.Permissions(self.permissions)
+
+        if "mention" not in kwargs:
+            self.mention = f"&{self.name}"
+
+    def __lt__(self, other):
+        """Simplified position-based comparisons similar to those of `discord.Role`."""
+        return self.position < other.position
+
+    def __ge__(self, other):
+        """Simplified position-based comparisons similar to those of `discord.Role`."""
+        return self.position >= other.position
+
 
 class MockGuild(CustomMockMixin, unittest.mock.Mock, HashableMixin):
     """
@@ -188,48 +226,6 @@ def roles(self) -> list[MockRole]:
         return [MockRole(name="@everyone", position=1, id=0)]
 
 
-# Create a Role instance to get a realistic Mock of `discord.Role`
-role_data = {"name": "role", "id": 1}
-role_instance = discord.Role(guild=guild_instance, state=unittest.mock.MagicMock(), data=role_data)
-
-
-class MockRole(CustomMockMixin, unittest.mock.Mock, ColourMixin, HashableMixin):
-    """
-    A Mock subclass to mock `discord.Role` objects.
-
-    Instances of this class will follow the specifications of `discord.Role` instances. For more
-    information, see the `MockGuild` docstring.
-    """
-    spec_set = role_instance
-
-    def __init__(self, **kwargs) -> None:
-        default_kwargs = {
-            "id": next(self.discord_id),
-            "name": "role",
-            "position": 1,
-            "colour": discord.Colour(0xdeadbf),
-            "permissions": discord.Permissions(),
-        }
-        super().__init__(**collections.ChainMap(kwargs, default_kwargs))
-
-        if isinstance(self.colour, int):
-            self.colour = discord.Colour(self.colour)
-
-        if isinstance(self.permissions, int):
-            self.permissions = discord.Permissions(self.permissions)
-
-        if "mention" not in kwargs:
-            self.mention = f"&{self.name}"
-
-    def __lt__(self, other):
-        """Simplified position-based comparisons similar to those of `discord.Role`."""
-        return self.position < other.position
-
-    def __ge__(self, other):
-        """Simplified position-based comparisons similar to those of `discord.Role`."""
-        return self.position >= other.position
-
-
 # Create a Member instance to get a realistic Mock of `discord.Member`
 member_data = {"user": "lemon", "roles": [1], "flags": 2}
 state_mock = unittest.mock.MagicMock()