Apply suggestions from code review

Co-authored-by: lemonyte <[email protected]>

Author: onerandomusername

bot/exts/advent_of_code/_cog.py

@@ -107,7 +107,7 @@ async def completionist_task(self) -> None:
         placement_leaderboard = json.loads(leaderboard["placement_leaderboard"])
 
         for member_aoc_info in placement_leaderboard.values():
-            if member_aoc_info["stars"] <= _helpers.STARS_THIS_YEAR:
+            if member_aoc_info["stars"] < _helpers.STARS_THIS_YEAR:
                 # Only give the role to people who have completed all stars for this year
                 continue
 

bot/exts/advent_of_code/_helpers.py

@@ -58,14 +58,14 @@
 
 # In 2025, AOC was changed to be held from Dec 1 to 12, with 12 days rather than 25.
 # This implementation is done in such a way that any arbitary number of days can be supported.
-def days_in_year(year:int | None = None) -> int:
+def days_in_year(year: int | None = None) -> int:
     """Return the number of days in the current Advent of Code year."""
     if year is None:
         year = AdventOfCode.year
     return 25 if year < 2025 else 12
 
 DAYS_THIS_YEAR = days_in_year()
-STARS_THIS_YEAR = DAYS_THIS_YEAR
+STARS_THIS_YEAR = DAYS_THIS_YEAR * 2
 
 class UnexpectedRedirect(aiohttp.ClientError):
     """Raised when an unexpected redirect was detected."""