Skip to content

Commit 585b90d

Browse files
authored
Refactor review policy by removing approval rules
Removed existing approval rules and disapproval options from the review policy.
1 parent 96e5f63 commit 585b90d

File tree

1 file changed

+3
-90
lines changed

1 file changed

+3
-90
lines changed

.github/review-policy.yml

Lines changed: 3 additions & 90 deletions
Original file line numberDiff line numberDiff line change
@@ -1,90 +1,3 @@
1-
policy:
2-
approval:
3-
- and:
4-
- core dev or events lead
5-
- staff or contributor
6-
- devops
7-
- devops (manual)
8-
- do not merge
9-
10-
# Rules for disapproving
11-
disapproval:
12-
options:
13-
# Both disapproving and approving should be handled through the GitHub UI
14-
methods:
15-
disapprove:
16-
github_review: true
17-
18-
revoke:
19-
github_review: true
20-
21-
# Any python-discord organisation member can leave a disapproving review
22-
requires:
23-
organizations: ["python-discord"]
24-
25-
26-
approval_rules:
27-
- name: core dev or events lead
28-
description: One approval from a Python Discord Core Developer or the Events Lead
29-
requires:
30-
count: 1
31-
users:
32-
- "janine9vn"
33-
teams:
34-
- "python-discord/core-developers"
35-
options:
36-
ignore_update_merges: true
37-
- name: staff or contributor
38-
description: Two members of the staff or contributors team must leave an approval
39-
requires:
40-
count: 2
41-
organizations: ["python-discord"]
42-
users:
43-
- ByteCommander
44-
- mathsman5133
45-
- slushiegoose
46-
- F4zii
47-
- kingdom5500
48-
- hedyhli
49-
- Refisio
50-
- riffautae
51-
- doublevcodes
52-
options:
53-
ignore_update_merges: true
54-
- name: devops
55-
description: If CI or Dockerfiles are changed then the DevOps team must be requested for a review
56-
requires:
57-
count: 1
58-
teams:
59-
- "python-discord/devops"
60-
if:
61-
changed_files:
62-
paths:
63-
- ".github/workflows/*"
64-
- "Dockerfile"
65-
options:
66-
request_review:
67-
enabled: true
68-
mode: teams
69-
ignore_update_merges: true
70-
- name: devops (manual)
71-
description: 'A manual request with the "review: needs devops" label'
72-
requires:
73-
count: 1
74-
teams:
75-
- "python-discord/devops"
76-
if:
77-
has_labels:
78-
- "review: needs devops"
79-
options:
80-
request_review:
81-
enabled: true
82-
mode: teams
83-
ignore_update_merges: true
84-
- name: do not merge
85-
description: "If the 'review: do not merge' tag is applied, merging is blocked"
86-
requires:
87-
count: 1
88-
users: ["ghost"] # We need a rule that cannot complete
89-
if:
90-
has_labels: ["review: do not merge"]
1+
remote: python-discord/.github
2+
path: review-policies/events.yml
3+
ref: main

0 commit comments

Comments
 (0)