Skip to content

Commit 8fdabfb

Browse files
committed
Use sets to compare 2 un-ordered lists.
1 parent c444b82 commit 8fdabfb

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

pydis_site/apps/api/tests/test_off_topic_channel_names.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,13 @@ def test_returns_name_in_list(self):
8181
response = self.client.get(url)
8282

8383
self.assertEqual(response.status_code, 200)
84-
self.assertListEqual(
85-
response.json(),
86-
[
84+
self.assertEqual(
85+
set(response.json()),
86+
{
8787
self.test_name.name,
8888
self.test_name_2.name,
8989
self.test_name_3.name
90-
]
90+
}
9191
)
9292

9393
def test_returns_two_items_with_random_items_param_set_to_2(self):
@@ -97,16 +97,17 @@ def test_returns_two_items_with_random_items_param_set_to_2(self):
9797

9898
self.assertEqual(response.status_code, 200)
9999
self.assertEqual(len(response.json()), 2)
100-
self.assertEqual(response.json(), [self.test_name.name, self.test_name_2.name])
100+
self.assertEqual(set(response.json()), {self.test_name.name, self.test_name_2.name})
101101

102102
def test_running_out_of_names_with_random_parameter(self):
103103
"""Reset names `used` parameter to `False` when running out of names."""
104104
url = reverse('bot:offtopicchannelname-list', host='api')
105105
response = self.client.get(f'{url}?random_items=3')
106106

107107
self.assertEqual(response.status_code, 200)
108-
self.assertListEqual(
109-
response.json(), [self.test_name.name, self.test_name_2.name, self.test_name_3.name]
108+
self.assertEqual(
109+
set(response.json()),
110+
{self.test_name.name, self.test_name_2.name, self.test_name_3.name}
110111
)
111112

112113
def test_returns_inactive_ot_names(self):
@@ -127,8 +128,8 @@ def test_returns_active_ot_names(self):
127128

128129
self.assertEqual(response.status_code, 200)
129130
self.assertEqual(
130-
response.json(),
131-
[self.test_name.name, self.test_name_2.name]
131+
set(response.json()),
132+
{self.test_name.name, self.test_name_2.name}
132133
)
133134

134135

0 commit comments

Comments
 (0)