Switch Out requests For httpx

The requests library has been replaced by httpx. It's a drop-in
replacement, but provides a better interface for certain things,
such as client sessions, and sync/async support.

Signed-off-by: Hassan Abouelela <[email protected]>

Author: HassanAbouelela

poetry.lock

@@ -36,7 +36,7 @@ def setUp(self):
         """Executed before each test method."""
         self.home_view = HomeView()
 
-    @mock.patch('requests.get', side_effect=mocked_requests_get)
+    @mock.patch('httpx.get', side_effect=mocked_requests_get)
     def test_returns_metadata(self, _: mock.MagicMock):
         """Test if the _get_repo_data helper actually returns what it should."""
         metadata = self.home_view._get_repo_data()
@@ -59,7 +59,7 @@ def test_returns_cached_metadata(self):
         self.assertIsInstance(metadata[0], RepositoryMetadata)
         self.assertIsInstance(str(metadata[0]), str)
 
-    @mock.patch('requests.get', side_effect=mocked_requests_get)
+    @mock.patch('httpx.get', side_effect=mocked_requests_get)
     def test_refresh_stale_metadata(self, _: mock.MagicMock):
         """Test if the _get_repo_data helper will refresh when the data is stale."""
         repo_data = RepositoryMetadata(
@@ -75,7 +75,7 @@ def test_refresh_stale_metadata(self, _: mock.MagicMock):
 
         self.assertIsInstance(metadata[0], RepositoryMetadata)
 
-    @mock.patch('requests.get', side_effect=mocked_requests_get)
+    @mock.patch('httpx.get', side_effect=mocked_requests_get)
     def test_returns_api_data(self, _: mock.MagicMock):
         """Tests if the _get_api_data helper returns what it should."""
         api_data = self.home_view._get_api_data()
@@ -86,7 +86,7 @@ def test_returns_api_data(self, _: mock.MagicMock):
         self.assertIn(repo, api_data.keys())
         self.assertIn("stargazers_count", api_data[repo])
 
-    @mock.patch('requests.get', side_effect=mocked_requests_get)
+    @mock.patch('httpx.get', side_effect=mocked_requests_get)
     def test_mocked_requests_get(self, mock_get: mock.MagicMock):
         """Tests if our mocked_requests_get is returning what it should."""
         success_data = mock_get(HomeView.github_api)
@@ -98,7 +98,7 @@ def test_mocked_requests_get(self, mock_get: mock.MagicMock):
         self.assertIsNotNone(success_data.json_data)
         self.assertIsNone(fail_data.json_data)
 
-    @mock.patch('requests.get')
+    @mock.patch('httpx.get')
     def test_falls_back_to_database_on_error(self, mock_get: mock.MagicMock):
         """Tests that fallback to the database is performed when we get garbage back."""
         repo_data = RepositoryMetadata(
@@ -117,7 +117,7 @@ def test_falls_back_to_database_on_error(self, mock_get: mock.MagicMock):
         [item] = metadata
         self.assertEqual(item, repo_data)
 
-    @mock.patch('requests.get')
+    @mock.patch('httpx.get')
     def test_falls_back_to_database_on_error_without_entries(self, mock_get: mock.MagicMock):
         """Tests that fallback to the database is performed when we get garbage back."""
         mock_get.return_value.json.return_value = ['garbage']

pydis_site/apps/home/tests/test_repodata_helpers.py

@@ -1,7 +1,7 @@
 import logging
 from typing import Dict, List
 
-import requests
+import httpx
 from django.core.handlers.wsgi import WSGIRequest
 from django.http import HttpResponse
 from django.shortcuts import render
@@ -56,12 +56,12 @@ def _get_api_data(self) -> Dict[str, Dict[str, str]]:
         repo_dict = {}
         try:
             # Fetch the data from the GitHub API
-            api_data: List[dict] = requests.get(
+            api_data: List[dict] = httpx.get(
                 self.github_api,
                 headers=self.headers,
                 timeout=settings.TIMEOUT_PERIOD
             ).json()
-        except requests.exceptions.Timeout:
+        except httpx.TimeoutException:
             log.error("Request to fetch GitHub repository metadata for timed out!")
             return repo_dict
 

pydis_site/apps/home/views/home.py

@@ -14,7 +14,7 @@ djangorestframework = "~=3.12.0"
 psycopg2-binary = "~=2.8.0"
 django-simple-bulma = "~=2.4"
 whitenoise = "~=5.0"
-requests = "~=2.21"
+httpx = "~=0.23.0"
 pyyaml = "~=5.1"
 gunicorn = "~=20.0.4"
 sentry-sdk = "~=0.19"