Merge pull request #768 from python-discord/fix-warnings

Fix Warnings & Enable In Tests

Author: jchristgit

.github/workflows/lint-test.yaml

@@ -53,6 +53,7 @@ jobs:
           CI: True
           DATABASE_URL: postgres://pysite:pysite@localhost:7777/pysite
           METRICITY_DB_URL: postgres://pysite:pysite@localhost:7777/metricity
+          PYTHONWARNINGS: error
 
       # This step will publish the coverage reports coveralls.io and
       # print a "job" link in the output of the GitHub Action

manage.py

@@ -7,6 +7,7 @@
 import django
 from django.contrib.auth import get_user_model
 from django.core.management import call_command, execute_from_command_line
+from django.test.utils import ignore_warnings
 
 DEFAULT_ENVS = {
     "DJANGO_SETTINGS_MODULE": "pydis_site.settings",
@@ -154,7 +155,16 @@ def run_server(self) -> None:
     def run_tests(self) -> None:
         """Prepare and run the test suite."""
         self.prepare_environment()
-        call_command(*sys.argv[1:])
+        # The whitenoise package expects a staticfiles directory to exist during startup,
+        # else it raises a warning. This is fine under normal application, but during
+        # tests, staticfiles are not, and do not need to be generated.
+        # The following line suppresses the warning.
+        # Reference: https://github.com/evansd/whitenoise/issues/215
+        with ignore_warnings(
+            message=r"No directory at: .*staticfiles",
+            module="whitenoise.base",
+        ):
+            call_command(*sys.argv[1:])
 
 
 def clean_up_static_files(build_folder: Path) -> None:

pydis_site/apps/api/__init__.py

@@ -1 +0,0 @@
-default_app_config = 'pydis_site.apps.api.apps.ApiConfig'

pydis_site/apps/api/tests/test_filterlists.py

@@ -64,8 +64,8 @@ def test_returns_filter_list_types(self):
 
         self.assertEqual(response.status_code, 200)
         for api_type, model_type in zip(response.json(), FilterList.FilterListType.choices):
-            self.assertEquals(api_type[0], model_type[0])
-            self.assertEquals(api_type[1], model_type[1])
+            self.assertEqual(api_type[0], model_type[0])
+            self.assertEqual(api_type[1], model_type[1])
 
 
 class CreationTests(AuthenticatedAPITestCase):

pydis_site/apps/api/viewsets/bot/aoc_completionist_block.py

@@ -70,4 +70,4 @@ class AocCompletionistBlockViewSet(
     serializer_class = AocCompletionistBlockSerializer
     queryset = AocCompletionistBlock.objects.all()
     filter_backends = (DjangoFilterBackend,)
-    filter_fields = ("user__id", "is_blocked")
+    filterset_fields = ("user__id", "is_blocked")

pydis_site/apps/api/viewsets/bot/aoc_link.py

@@ -68,4 +68,4 @@ class AocAccountLinkViewSet(
     serializer_class = AocAccountLinkSerializer
     queryset = AocAccountLink.objects.all()
     filter_backends = (DjangoFilterBackend,)
-    filter_fields = ("user__id", "aoc_username")
+    filterset_fields = ("user__id", "aoc_username")

pydis_site/apps/api/viewsets/bot/infraction.py

@@ -154,7 +154,7 @@ class InfractionViewSet(
     queryset = Infraction.objects.all()
     pagination_class = LimitOffsetPaginationExtended
     filter_backends = (DjangoFilterBackend, SearchFilter, OrderingFilter)
-    filter_fields = ('user__id', 'actor__id', 'active', 'hidden', 'type')
+    filterset_fields = ('user__id', 'actor__id', 'active', 'hidden', 'type')
     search_fields = ('$reason',)
     frozen_fields = ('id', 'inserted_at', 'type', 'user', 'actor', 'hidden')
 

pydis_site/apps/api/viewsets/bot/nomination.py

@@ -172,7 +172,7 @@ class NominationViewSet(CreateModelMixin, RetrieveModelMixin, ListModelMixin, Ge
     serializer_class = NominationSerializer
     queryset = Nomination.objects.all()
     filter_backends = (DjangoFilterBackend, SearchFilter, OrderingFilter)
-    filter_fields = ('user__id', 'active')
+    filterset_fields = ('user__id', 'active')
     frozen_fields = ('id', 'inserted_at', 'user', 'ended_at')
     frozen_on_create = ('ended_at', 'end_reason', 'active', 'inserted_at', 'reviewed')
 

pydis_site/apps/api/viewsets/bot/reminder.py

@@ -125,4 +125,4 @@ class ReminderViewSet(
     serializer_class = ReminderSerializer
     queryset = Reminder.objects.prefetch_related('author')
     filter_backends = (DjangoFilterBackend, SearchFilter)
-    filter_fields = ('active', 'author__id')
+    filterset_fields = ('active', 'author__id')

pydis_site/apps/api/viewsets/bot/user.py

@@ -237,7 +237,7 @@ class UserViewSet(ModelViewSet):
     queryset = User.objects.all().order_by("id")
     pagination_class = UserListPagination
     filter_backends = (DjangoFilterBackend,)
-    filter_fields = ('name', 'discriminator')
+    filterset_fields = ('name', 'discriminator')
 
     def get_serializer(self, *args, **kwargs) -> ModelSerializer:
         """Set Serializer many attribute to True if request body contains a list."""