Commit 3bd19e6
Handle
Usually, when `distro` is used in Windows, it returns nothing. Any call to `lsb_release`, `uname', etc, raises a `[[WinError 2] The system cannot find the file specified` error, which is properly handled.
However, in a particular environment where I've run it, I've found that the call to `uname` raises a `CalledProcessError`, because a Policy or a Security Control is injecting a non-zero return code:
```
t=2024-10-04T15:13:39+0200 Command '('uname', '-rs')' returned non-zero exit status 3221225794.
Traceback (most recent call last):
File "C:\...\main.py", line 123, in __check_supported_platform
distro_id = distro.id()
^^^^^^^^^^^
File "C:\...\site-packages\distro\distro.py", line 284, in id
return _distro.id()
^^^^^^^^^^^^
File "C:\...\site-packages\distro\distro.py", line 855, in id
distro_id = self.uname_attr("id")
^^^^^^^^^^^^^^^^^^^^^
File "C:\...\site-packages\distro\distro.py", line 1088, in uname_attr
return self._uname_info.get(attribute, "")
^^^^^^^^^^^^^^^^
File "C:\...\lib\functools.py", line 995, in __get__
val = self.func(instance)
^^^^^^^^^^^^^^^^^^^
File "C:\...\site-packages\distro\distro.py", line 1202, in _uname_info
stdout = subprocess.check_output(cmd, stderr=subprocess.DEVNULL)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\...\lib\subprocess.py", line 466, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\...\lib\subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '('uname', '-rs')' returned non-zero exit status 3221225794.
```
We do handle `CalledProcessError` in other calls, so I'm adding to
`uname` too.CalledProcessError when calling uname
1 parent 7ce285c commit 3bd19e6
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1204 | 1204 | | |
1205 | 1205 | | |
1206 | 1206 | | |
1207 | | - | |
| 1207 | + | |
1208 | 1208 | | |
1209 | 1209 | | |
1210 | 1210 | | |
| |||
0 commit comments