Skip to content

Commit ba1be15

Browse files
committed
Refactor: return PoProjectStats from completion module
1 parent 571488a commit ba1be15

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

completion.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ def branches_from_devguide(devguide_dir: Path) -> list[str]:
2020
]
2121

2222

23-
def get_completion(
23+
def get_stats(
2424
clones_dir: str, repo: str
25-
) -> tuple[float, 'TranslatorsData', str, float]:
25+
) -> tuple[potodo.PoProjectStats, 'TranslatorsData', str, float]:
2626
clone_path = Path(clones_dir, 'translations', repo)
2727
for branch in branches_from_devguide(Path(clones_dir, 'devguide')) + [
2828
'master',
@@ -43,15 +43,15 @@ def get_completion(
4343
translators_data = TranslatorsData(translators_number, translators_link)
4444
break
4545
path_for_merge = Path(clones_dir, 'rebased_translations', repo)
46-
completion = potodo.merge_and_scan_path(
46+
po_project = potodo.merge_and_scan_path(
4747
clone_path,
4848
pot_path=Path(clones_dir, 'cpython/Doc/build/gettext'),
4949
merge_path=path_for_merge,
5050
hide_reserved=False,
5151
api_url='',
52-
).completion
52+
)
5353

54-
if completion:
54+
if po_project.completion:
5555
# Fetch commit from before 30 days ago and checkout
5656
try:
5757
commit = next(
@@ -73,9 +73,9 @@ def get_completion(
7373
else:
7474
month_ago_completion = 0.0
7575

76-
change = completion - month_ago_completion
76+
change = po_project.completion - month_ago_completion
7777

78-
return completion, translators_data, branch, change
78+
return po_project, translators_data, branch, change
7979

8080

8181
@dataclass(frozen=True)

generate.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@
77
from dataclasses import dataclass, asdict
88
from datetime import datetime, timezone
99
from pathlib import Path
10+
from types import SimpleNamespace
1011

1112
from git import Repo
1213
from jinja2 import Template
1314
from urllib3 import PoolManager
1415

1516
import build_status
1617
import contribute
17-
from completion import branches_from_devguide, get_completion, TranslatorsData
18+
from completion import branches_from_devguide, get_stats, TranslatorsData
1819
from repositories import Language, get_languages_and_repos
1920
from word_count import get_word_count
2021

@@ -56,17 +57,17 @@ def get_project_data(
5657
) -> 'LanguageProjectData':
5758
built = language.code in languages_built
5859
if repo:
59-
completion, translators_data, branch, change = get_completion(clones_dir, repo)
60+
stats, translators_data, branch, change = get_stats(clones_dir, repo)
6061
else:
61-
completion = 0.0
62+
stats = SimpleNamespace(completion=0.0)
6263
translators_data = TranslatorsData(0, False)
6364
change = 0.0
6465
branch = ''
6566
return LanguageProjectData(
6667
language,
6768
repo,
6869
branch,
69-
completion,
70+
stats.completion,
7071
change,
7172
translators_data,
7273
built,

0 commit comments

Comments
 (0)