Don't link from language name, move repo link as contrib link fallback

Author: m-aciek

contribute.py

@@ -1,5 +1,3 @@
-from typing import Literal
-
 pulling_from_transifex = ('zh-cn', 'pt-br', 'ja', 'uk', 'pl')
 
 custom_contributing_links = {
@@ -13,13 +11,23 @@
 }
 
 
-def get_contrib_link(language: str) -> str | Literal[False]:
-    return custom_contributing_links.get(language) or (
-        language in pulling_from_transifex
-        and 'https://explore.transifex.com/python-doc/python-newest/'
+def get_contrib_link(language: str, repo: str | None) -> str | None:
+    return (
+        custom_contributing_links.get(language)
+        or (
+            language in pulling_from_transifex
+            and 'https://explore.transifex.com/python-doc/python-newest/'
+        )
+        or (repo and f'https://github.com/{repo}')
     )
 
 
 if __name__ == '__main__':
-    for code in ('en', 'pl', 'ar', 'zh-cn', 'id'):
-        print(f'{code}: {get_contrib_link(code)}')
+    for code, repo in (
+        ('en', None),
+        ('pl', None),
+        ('ar', 'python/python-docs-ar'),
+        ('zh-cn', None),
+        ('id', None),
+    ):
+        print(f'{code}: {get_contrib_link(code, repo)}')

generate.py

@@ -40,7 +40,7 @@ def get_completion_progress() -> (
             bool,
             bool | None,
             bool,
-            str | Literal[False],
+            str | None,
         ]
     ]
 ):
@@ -68,7 +68,7 @@ def get_completion_progress() -> (
             built = lang in languages_built
             in_switcher = languages_built.get(lang)
             tx = lang in contribute.pulling_from_transifex
-            contrib_link = contribute.get_contrib_link(lang)
+            contrib_link = contribute.get_contrib_link(lang, repo)
             if not repo:
                 yield (
                     lang,
@@ -81,7 +81,7 @@ def get_completion_progress() -> (
                     built,
                     in_switcher,
                     False,
-                    False,
+                    None,
                 )
                 continue
             completion, translators, translators_link = get_completion(clones_dir, repo)

template.html.jinja

@@ -19,16 +19,8 @@
 <tbody>
 {% for language, language_name, repo, completion, translators, translators_link, visitors, build, in_switcher, on_platform, contrib_link in completion_progress | sort(attribute='2,3') | reverse %}
 <tr>
-  {% if repo %}
-  <td data-label="language">
-    <a href="https://github.com/{{ repo }}" target="_blank">
-      {{ language_name }} ({{ language }})
-    </a>
-  </td>
-  {% else %}
-  <td data-label="language">{{ language }}</td>
-  {% endif %}
-      <td data-label="contribute">
+  <td data-label="language">{{ language_name }} ({{ language }})</td>
+  <td data-label="contribute">
     {% if contrib_link %}<a href="{{ contrib_link }}" target="_blank">{% endif %}
     {% if on_platform %}platform{% else %}repository{% endif %}
     {% if contrib_link %}</a>{% endif %}