(Hopefully final) Review

StanFromIreland · StanFromIreland · commit da07650250c8 · 2025-07-30T09:31:50.000+02:00
diff --git a/generate.py b/generate.py
@@ -120,17 +120,9 @@ class LanguageProjectData:
         counts=counts,
     )
 
-    chart = env.get_template('chart.html.jinja').render(
-        completion_progress=completion_progress,
-        generation_time=generation_time,
-        duration=(datetime.now(timezone.utc) - generation_time).seconds,
-        counts=counts,
-    )
-
     Path('build/style.css').write_bytes(Path('src/style.css').read_bytes())
     Path('build/logo.png').write_bytes(Path('src/logo.png').read_bytes())
     Path('build/index.html').write_text(index)
-    Path('build/chart.html').write_text(chart)
 
     Path('build/index.json').write_text(
         json.dumps([asdict(project) for project in completion_progress], indent=2)
diff --git a/src/style.css b/src/style.css
@@ -1,4 +1,4 @@
-/* ------------------------ GLOBAL STYLES -------------------------- */
+/* ---------------------------- Global Styles ------------------------------- */
 
 body {
   padding-top: 4.5rem;
@@ -17,7 +17,7 @@ a:hover {
   color: #1595fe;
 }
 
-/* --------------------------- NAVBAR ------------------------------ */
+/* -------------------------------- navbar ---------------------------------- */
 
 .navbar {
   background-color: rgb(245, 245, 245, 0.6);
@@ -54,22 +54,11 @@ a:hover {
 }
 
 .card:hover {
-  background: linear-gradient(90deg, #cc9add 8.06%, #ebad98 106.93%);
   text-decoration: none;
   transform: scale(1.05);
   transition: all 0.3s ease-in-out;
 }
 
-.card:hover .card-title,
-.card:hover .card-subtitle,
-.card:hover .card-text {
-  color: white;
-}
-
-.card:hover .card-link {
-  color: rgb(231, 231, 231);
-}
-
 @media (min-width: 768px) {
   .card {
     flex-basis: calc(33.33% - 30px);
@@ -95,7 +84,7 @@ a:hover {
   border-bottom-left-radius: 3px;
 }
 
-/* ------------------------------ Tables ------------------------------------ */
+/* ------------------------------ Metadata ---------------------------------- */
 
 table {
   border-collapse: collapse;
@@ -112,48 +101,9 @@ th {
 hr {
   color: #f4f4f4;
 }
-.progress-bar {
-  display: inline-block;
-  color: white;
-  height: 20px;
-  line-height: 20px;
-  text-align: center;
-  overflow: hidden;
-  white-space: nowrap;
-  box-sizing: border-box;
-}
-.progress-bar-outer-label {
-  display: none;
-  padding-left: .5em;
-  height: 20px;
-  line-height: 20px;
-  overflow: hidden;
-}
-.progress-bar.low {
-  color: transparent;
-  user-select: none;
-}
-.progress-bar.low + .progress-bar-outer-label {
-  display: inline-block;
-}
-td[data-label="translators"], td[data-label="warnings"], td[data-label="lint"] {
+td[data-label="warnings"], td[data-label="lint"] {
   text-align: right;
 }
-td[data-label="completion"] {
-  width: 100%;
-  line-height: 0;
-}
-.switchpages{
-    position: absolute;
-    top: 10px;
-    right: 10px;
- }
-
-@media screen and (max-width: 675px) {
-  .switchpages{
-    all: unset;
- }
-}
 
 @media screen and (max-width: 600px) {
   table, thead, tbody, th, td, tr {
@@ -180,11 +130,4 @@ td[data-label="completion"] {
     left: 10px;
     position: absolute;
   }
-  td[data-label="completion"] {
-    width: inherit;
-  }
-  .progress-bar {
-    min-width: 0;
-    width: 100% !important;
-  }
 }
diff --git a/templates/base.html.jinja b/templates/base.html.jinja
@@ -4,8 +4,7 @@
 <head>
   <meta charset="utf-8">
   <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-  <meta name="description" content="">
-  <meta name="author" content="">
+  <meta name="description" content="Python Documentation Translation Dashboard">
 
   <title>Python Docs Translation Dashboard</title>
 
@@ -32,9 +31,6 @@
 
       <div class="collapse navbar-collapse" id="navbarNavDropdown">
         <ul class="navbar-nav mr-auto">
-          <li class="nav-item">
-            <a class="nav-link" href="chart.html">Chart</a>
-          </li>
           <li class="nav-item">
             <a class="nav-link" href="metadata.html">Metadata</a>
           </li>
diff --git a/templates/chart.html.jinja b/templates/chart.html.jinja
diff --git a/templates/index.html.jinja b/templates/index.html.jinja
@@ -8,7 +8,7 @@
             <div class="card shadow mb-3 w-100">
               <div class="card-body">
                 <h5 class="card-subtitle text-muted">{{ project.translated_name }}</h5>
-                <h4 class="card-title">{{ project.language.name }} ({{ project.language.code }})</h4>
+                <h4 class="card-title">{{ project.language.name }}</h4>
                 <h5 class="card-subtitle mb-2">Completion: <strong>{{ '{:.2f}%'.format(project.completion) }}</strong></h5>
                 <h6 class="card-subtitle mb-2 text-muted">30 Days Progress: {{ '{:.2f}%'.format(project.change) }}</h6>
                 <h6 class="card-subtitle mb-2 text-muted">Translators: {{ project.translators.number }}</h6>
@@ -45,5 +45,9 @@
       </div>
     </div>
 
-  <p style="text-align: center;">Last updated on {{ generation_time.strftime('%A, %-d %B %Y, %-H:%M:%S %Z') }} (in {{ duration // 60 }}:{{ "{:02}".format(duration % 60) }} minutes).</p>
+  <p style="text-align: center;">
+    Last updated on {{ generation_time.strftime('%A, %-d %B %Y, %-H:%M:%S %Z') }} (in {{ duration // 60 }}:{{ "{:02}".format(duration % 60) }} minutes).<br/>
+    You can find the scripts used to generate this website <a href="https://github.com/python-docs-translations/dashboard/">on GitHub</a>.<br/>
+    You can download the data on this page in <a href="https://github.com/python-docs-translations/dashboard/blob/gh-pages/index.json">JSON format</a>.
+  </p>
 {% endblock %}
