Skip to content

Conversation

@StanFromIreland
Copy link
Member

I've added a simple Light/Darkmode toggle. I also capitalized table headings and rounded table corners for aesthetic.
Icons are from Googles open source collection.

Renders

Note: Hardcoded test data was used.

image
image

@StanFromIreland StanFromIreland marked this pull request as ready for review November 26, 2024 16:03
@hugovk
Copy link
Member

hugovk commented Nov 26, 2024

On first load it looks like this:

image

I have my OS in dark mode, can we have it autodetect?

Then when I click the icon, the table header text and branch names remain in black. The language text links are also hard to read:

image

And clicking the icon again, the header and branch names switch to white:

image

@StanFromIreland
Copy link
Member Author

I will look into why it dosen't work in different browsers as I only tested if Firefox and everything seemed ok.

@StanFromIreland StanFromIreland marked this pull request as draft December 4, 2024 19:01
@m-aciek
Copy link
Collaborator

m-aciek commented Jan 13, 2025

I learned today that the browser/OS preference can be checked with a media query:

@media (prefers-color-scheme: dark) {
  body {background-color: #2f2f2f;}
}

Maybe a first iteration could be without the toggle, just basing on the OS preferences?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants