Update release-cycle.json URL #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
reviewed
Nov 10, 2025
completion.py
Outdated
| from functools import cache | ||
| from pathlib import Path | ||
| from tempfile import TemporaryDirectory | ||
| from urllib.request import urlopen |
Member
There was a problem hiding this comment.
This project already requires both requests (via Sphinx) and urllib3 (directly), perhaps we should use one of the two?
Closed
StanFromIreland
requested changes
Nov 10, 2025
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
Please fix it's usage:
Line 17 in afdc452
AA-Turner
reviewed
Nov 10, 2025
Co-authored-by: Adam Turner <[email protected]>
AA-Turner
approved these changes
Nov 10, 2025
Member
AA-Turner
left a comment
AA-Turner
left a comment
There was a problem hiding this comment.
CI failing on git permission error; unrelated.
A
AA-Turner
merged commit 3da40df
into
python-docs-translations:main
3 of 4 checks passed
Member
|
Yes, you need to create a branch in this repository for it to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.