Merge pull request #1 from python-effect/py3

get rid of exc_info-using code to be compatible with new release of Effect

Author: radix

.travis.yml

@@ -2,15 +2,15 @@ sudo: false
 
 language: python
 python:
-    - "2.7"
-    - "2.6"
-    - "3.4"
-    - "pypy"
+    - "3.6"
+    - "3.7"
+    - "3.8"
+    - "pypy3"
 install:
     - pip install -r dev-requirements.txt
     - pip install .
 script:
-    - make lint
+    - flake8
     - py.test
     - make doc
 

Makefile

@@ -1,6 +1,3 @@
-lint:
-	flake8 --ignore=E131,E731,W503 txeffect/
-
 build-dist:
 	rm -rf dist
 	python setup.py sdist bdist_wheel

setup.cfg

@@ -3,3 +3,7 @@
 # 3. If at all possible, it is good practice to do this. If you cannot, you
 # will need to generate wheels for each Python version that you support.
 universal=1
+
+[flake8]
+max-line-length = 100
+ignore = E131,E731,W503

setup.py

@@ -13,7 +13,7 @@
         'License :: OSI Approved :: MIT License',
         'Programming Language :: Python :: 2',
         'Programming Language :: Python :: 3',
-        ],
+    ],
     packages=['txeffect'],
     install_requires=['effect', 'twisted'],
-    )
+)

txeffect/__init__.py

@@ -13,29 +13,25 @@
 does.
 """
 
-from __future__ import absolute_import
-
 from functools import partial
-import sys
 
 from twisted.internet.defer import Deferred
-from twisted.python.failure import Failure
 from twisted.internet.task import deferLater
 
 from effect import (
     Delay,
     ParallelEffects,
     perform as base_perform,
     TypeDispatcher)
-from effect.async import perform_parallel_async
+from effect.parallel_async import perform_parallel_async
 from effect._utils import wraps  # whoah there
 
 
 def deferred_to_box(d, box):
     """
     Make a Deferred pass its success or fail events on to the given box.
     """
-    d.addCallbacks(box.succeed, lambda f: box.fail((f.type, f.value, f.tb)))
+    d.addCallbacks(box.succeed, lambda f: box.fail(f.value))
 
 
 def make_twisted_dispatcher(reactor):
@@ -71,8 +67,8 @@ def deferred_wrapper(*args, **kwargs):
         pass_args = args[:-1]
         try:
             result = f(*pass_args, **kwargs)
-        except:
-            box.fail(sys.exc_info())
+        except Exception as e:
+            box.fail(e)
         else:
             if isinstance(result, Deferred):
                 deferred_to_box(result, box)
@@ -97,11 +93,6 @@ def perform(dispatcher, effect):
     d = Deferred()
     eff = effect.on(
         success=d.callback,
-        error=lambda e: d.errback(exc_info_to_failure(e)))
+        error=lambda e: d.errback(e))
     base_perform(dispatcher, eff)
     return d
-
-
-def exc_info_to_failure(exc_info):
-    """Convert an exc_info tuple to a :class:`Failure`."""
-    return Failure(exc_info[1], exc_info[0], exc_info[2])

txeffect/test_txeffect.py

@@ -1,10 +1,9 @@
 from __future__ import absolute_import
 
 from functools import partial
-import sys
 
 from testtools import TestCase
-from testtools.matchers import MatchesListwise, Equals, MatchesException
+from testtools.matchers import MatchesListwise, Equals
 
 from twisted.trial.unittest import SynchronousTestCase
 from twisted.internet.defer import Deferred
@@ -16,9 +15,9 @@
     base_dispatcher, parallel,
     ComposedDispatcher,
 )
+from effect._test_utils import MatchesException
 from . import (
     deferred_performer,
-    exc_info_to_failure,
     make_twisted_dispatcher,
     perform)
 
@@ -95,14 +94,22 @@ def test_perform_failure(self):
         effect.twisted.perform fails the Deferred it returns if the ultimate
         result of the Effect is an exception.
         """
+        try:
+            raise ValueError("oh dear")
+        except Exception as e:
+            exc = e
+
         boxes = []
         e = Effect(boxes.append)
         d = perform(func_dispatcher, e)
         self.assertNoResult(d)
-        boxes[0].fail((ValueError, ValueError("oh dear"), None))
+        boxes[0].fail(exc)
         f = self.failureResultOf(d)
         self.assertEqual(f.type, ValueError)
         self.assertEqual(str(f.value), 'oh dear')
+        self.assertRegex(
+            f.getTraceback().splitlines()[-3],
+            r'^\s+File ".*?test_txeffect.py", line \d+, in test_perform_failure$')
 
 
 class DeferredPerformerTests(TestCase):
@@ -219,22 +226,3 @@ def p(dispatcher, intent, extra):
         dispatcher = lambda _: partial(p, extra='extra val')
         result = self.successResultOf(perform(dispatcher, Effect('foo')))
         self.assertEqual(result, 'extra val')
-
-
-class ExcInfoToFailureTests(TestCase):
-    """Tests for :func:`exc_info_to_failure`."""
-
-    def test_exc_info_to_failure(self):
-        """
-        :func:`exc_info_to_failure` converts an exc_info tuple to a
-        :obj:`Failure`.
-        """
-        try:
-            raise RuntimeError("foo")
-        except:
-            exc_info = sys.exc_info()
-
-        failure = exc_info_to_failure(exc_info)
-        self.assertIs(failure.type, RuntimeError)
-        self.assertEqual(str(failure.value), "foo")
-        self.assertIs(failure.tb, exc_info[2])