Added more test

Author: eadwinCode

ellar_cli/service/cli.py

@@ -4,7 +4,6 @@
 import sys
 import typing as t
 
-import click
 from ellar.app import App
 from ellar.app.context import ApplicationContext
 from ellar.common.constants import ELLAR_CONFIG_MODULE
@@ -298,7 +297,7 @@ def _import_from_string(self) -> t.Any:
             message = (
                 'Attribute "{attrs_str}" not found in python module "{module_file}".'
             )
-            raise click.ClickException(
+            raise EllarCLIException(
                 message.format(attrs_str=attrs_str, module_file=module.__file__)
             ) from attr_ex
         return instance

tests/sample_app/apps/bad_app_3.py

@@ -0,0 +1,15 @@
+#!/bin/env python
+from ellar.app import AppFactory
+from ellar.samples import HomeModule
+
+from ellar_cli.main import create_ellar_cli
+
+
+def bootstrap():
+    AppFactory.create_app(modules=[HomeModule])
+
+
+cli = create_ellar_cli("apps.bad_app_3:bootstrap")
+
+if __name__ == "__main__":
+    cli()

tests/test_ellar_cli_service.py

@@ -218,3 +218,14 @@ def test_apps_bad_app_2_fails(change_os_dir):
         b'Error: Attribute "bootstrap_unknown" not found in python module'
         in result.stderr
     )
+
+
+def test_apps_bad_app_3_fails(change_os_dir):
+    result = subprocess.run(
+        ["python", "apps/bad_app_3.py"], stdout=subprocess.PIPE, stderr=subprocess.PIPE
+    )
+    assert result.returncode == 1
+    assert (
+        result.stderr
+        == b"Error: Boostrap Function must return Instance of `ellar.app.App` type\n"
+    )