Added more tests to improve test-coverage

Author: eadwinCode

ellar_cli/service/cli.py

@@ -214,7 +214,7 @@ def import_configuration(self) -> t.Type["Config"]:
     @_export_ellar_config_module
     def get_application_config(self) -> "Config":
         assert self._meta
-        if not self._store.config_instance:
+        if not self._store.config_instance:  # pragma: no cover
             self._store.config_instance = Config(
                 os.environ.get(ELLAR_CONFIG_MODULE, self._meta.config)
             )
@@ -302,11 +302,11 @@ def _import_from_string(self) -> t.Any:
             ) from attr_ex
         return instance
 
-    def import_configuration(self) -> t.Type[Config]:  # pragma: no cover
-        raise Exception("Not Available")
+    def import_configuration(self) -> t.Type[Config]:
+        raise EllarCLIException("Not Available")
 
     def get_application_config(self) -> Config:
         return self.import_application().config
 
-    def import_root_module(self) -> t.Type[ModuleBase]:  # pragma: no cover
-        raise Exception("Not Available")
+    def import_root_module(self) -> t.Type[ModuleBase]:
+        raise EllarCLIException("Not Available")

tests/sample_app/apps/good_app.py

@@ -1,9 +1,12 @@
 #!/bin/env python
 import click
 from ellar.app import AppFactory
+from ellar.core import Config
 from ellar.samples import HomeModule
 
+from ellar_cli.constants import ELLAR_META
 from ellar_cli.main import create_ellar_cli
+from ellar_cli.service import EllarCLIService
 
 
 def bootstrap():
@@ -15,9 +18,33 @@ def bootstrap():
 
 
 @cli.command()
-def working():
+@click.pass_context
+def working(ctx: click.Context):
+    ellar_cli_service: EllarCLIService = ctx.meta.get(ELLAR_META)
+    assert isinstance(ellar_cli_service.get_application_config(), Config)
     click.echo("Working")
 
 
+@cli.command()
+@click.pass_context
+def failing_1(ctx: click.Context):
+    ellar_cli_service: EllarCLIService = ctx.meta.get(ELLAR_META)
+    ellar_cli_service.import_configuration()
+
+
+@cli.command()
+@click.pass_context
+def failing_2(ctx: click.Context):
+    ellar_cli_service: EllarCLIService = ctx.meta.get(ELLAR_META)
+    ellar_cli_service.import_configuration()
+
+
+@cli.command()
+@click.pass_context
+def failing_3(ctx: click.Context):
+    ellar_cli_service: EllarCLIService = ctx.meta.get(ELLAR_META)
+    ellar_cli_service.import_root_module()
+
+
 if __name__ == "__main__":
     cli()

tests/test_ellar_cli_service.py

@@ -198,6 +198,34 @@ def test_apps_good_app_cli_works(change_os_dir):
     assert result.stdout == good_app_info
 
 
+def test_apps_good_app_working_command(change_os_dir):
+    result = subprocess.run(
+        ["python", "apps/good_app.py", "working"], stdout=subprocess.PIPE
+    )
+    assert result.returncode == 0
+    assert result.stdout == b"Working\n"
+
+
+def test_apps_good_app_failing_commands(change_os_dir):
+    result = subprocess.run(
+        ["python", "apps/good_app.py", "failing-1"], stderr=subprocess.PIPE
+    )
+    assert result.returncode == 1
+    assert result.stderr == b"Error: Not Available\n"
+
+    result = subprocess.run(
+        ["python", "apps/good_app.py", "failing-2"], stderr=subprocess.PIPE
+    )
+    assert result.returncode == 1
+    assert result.stderr == b"Error: Not Available\n"
+
+    result = subprocess.run(
+        ["python", "apps/good_app.py", "failing-3"], stderr=subprocess.PIPE
+    )
+    assert result.returncode == 1
+    assert result.stderr == b"Error: Not Available\n"
+
+
 def test_apps_bad_app_fails(change_os_dir):
     result = subprocess.run(
         ["python", "apps/bad_app.py"], stdout=subprocess.PIPE, stderr=subprocess.PIPE